Canonicalises feed base URL handling - #41
Conversation
| $NNTP_HOST = getenv('NNTP_HOST'); | ||
| } | ||
|
|
||
| $NEWS_WEB_BASE_URL = 'https://news.php.net'; |
There was a problem hiding this comment.
| $NEWS_WEB_BASE_URL = 'https://news.php.net'; | |
| $NEWS_WEB_BASE_URL = 'https://news-web.php.net'; |
There was a problem hiding this comment.
Thanks, @jimwins! Your suggestion is technically correct. However, current master for whatever reason references news.php.net -- which would be fine for local, but it does in fact not reflect remote reality.
https://github.com/search?q=repo%3Aphp%2Fweb-news+news.php.net&type=code
Are we fine making it part of this PR's scope to unify it to news-web.php.net?
There was a problem hiding this comment.
news.php.net actually works, but redirects to news-web.php.net so requests get routed through the CDN. I wish we could figure out how to have the web interface live at lists.php.net, but I guess that has proven difficult for DNS/CDN reasons, so we may as well be consistent in using news-web.
2 participants
Private fork follow up. Uses the configured base URL for RSS/RDF links instead of the request host header.