Skip to content

Create Devcontainer config#1189

Merged
derickr merged 5 commits into
php:masterfrom
garrettw:master
Jul 31, 2025
Merged

Create Devcontainer config#1189
derickr merged 5 commits into
php:masterfrom
garrettw:master

Conversation

@garrettw
Copy link
Copy Markdown
Contributor

Picks up where #995 left off, since the idea didn't seem objectionable.

Copy link
Copy Markdown
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense to me. Thank you!

Comment thread .devcontainer/devcontainer.json
@garrettw garrettw requested a review from sgolemon as a code owner July 27, 2025 16:26
Copy link
Copy Markdown
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contents LGTM.

Comment thread .devcontainer/devcontainer.json Outdated
Copy link
Copy Markdown
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a question.

Comment thread .devcontainer/post-create.sh
@derickr derickr merged commit b53f8f1 into php:master Jul 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants