Repository navigation
Run EPV through the organization's strict EPV workflow - #48
Merged
Merged
Conversation
EPV exits 0 on Error findings, so they never failed this workflow, and pointing it at the extension folder gave a false "Packaging structure" error. EPV now runs in an epv job that calls phpbbmodders/.github's reusable EPV workflow (v1), which fails on any Fatal or Error finding not listed in .github/epv-allowed.txt. .github/epv-allowed.txt lists this extension's justified findings, each with its reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches this extension's EPV (Extension Pre Validator) check to the organization's strict EPV workflow,
phpbbmodders/.github/.github/workflows/epv.yml@v1(phpbbmodders/.github#2), as piloted in phpbbmodders/contactadmin#46.Why
phpBB/ext/instead..github/epv-allowed.txt.Changes
tests.yml: phpbb-extensions/test-framework is called withEPV: 0, so it no longer runs EPV itself; its other checks are unchanged.epvjob calling the shared workflow for phpBB 3.3.x.Allowed EPV findings (new
.github/epv-allowed.txt, each with its reason)Error: Using htmlspecialchars in /event/banhammer_listener.php: The ban-domain value is escaped with ENT_QUOTES on purpose (see the comment above it); utf8_htmlspecialchars() would only use ENT_COMPAT.Error: Using unserialize in /migrations/v101_data.php: Released migration: reads the extension's own banhammer_settings config_text from its previous version, with allowed_classes off. Released migrations must not be changed.Testing
Claude ran EPV (
phpbb/epvdev-master) locally on this branch, pointed at the folder containingphpbbmodders/banhammer. Its only Fatal or Error findings are the ones listed above, and the shared workflow's filter passes with this allowlist. This PR's CI is the first run of the new job here.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code