Skip to content

Get CI running again - #2

Merged
bonelifer merged 4 commits into
masterfrom
runner-image
Oct 19, 2026
Merged

bonelifer merged 4 commits into
masterfrom
runner-image

Conversation

@bonelifer

@bonelifer bonelifer commented Oct 19, 2026 •

Copy link
Copy Markdown

Gets this extension's CI running again. Its jobs had been stuck in the queue on a retired runner image.

Changes

  • Runner image: ubuntu-18.04 is retired, so every job stayed queued and never ran, including on the strict-EPV PR. The workflow now pins ubuntu-24.04. That's not ubuntu-22.04, which is deprecated with brownouts, and not ubuntu-latest, which moves to Ubuntu 26.04 from 10/19/2026.
  • PHP versions: the jobs ran PHP 7.1, which phpBB 3.3 no longer supports (it needs 7.2, and its bundled Composer refuses to run on 7.1). The basic checks job now uses PHP 7.4.
  • PHP requirement: raised from 7.1.3 to 7.4, the lowest version phpbbmodders extensions support, in composer.json, ext.php's enable check and the README.
  • Database jobs removed: the extension has no PHPUnit tests, so the MySQL, PostgreSQL, SQLite and MSSQL jobs only checked that phpBB installs. On PHP 8 they failed outright, because PHPUnit 9 stops when the tests folder is missing. They can come back if tests are written.

Testing

CI on this PR passes: the basic checks job (code sniffer, image and executable-file checks, EPV) on PHP 7.4 and Ubuntu 24.04. While the database jobs were still in place, this PR's CI ran them once on Ubuntu 24.04: they passed on PHP 7.4 for PostgreSQL, SQLite, MySQL 5.6 and MariaDB 10.4–10.5. The PHP 8 jobs then failed on the missing tests folder, which is why they were removed.

Sources: actions/runner-images#14254 (Ubuntu 22.04 deprecation) and GitHub's ubuntu-latest to 26.04 migration notice.


Investigated and written by Claude on behalf of William Jacoby (bonelifer).

🤖 Generated with Claude Code

GitHub has retired the ubuntu-18.04 runner image, so these jobs stayed
queued and never ran. ubuntu-22.04 is deprecated and ubuntu-latest is
moving to Ubuntu 26.04, so the workflows now pin ubuntu-24.04.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
phpBB 3.3 requires PHP 7.2 or later, and its bundled Composer refuses to
run on PHP 7.1, so the PHP 7.1 jobs could never pass. The matrix now
covers PHP 7.4 to 8.2, the range phpbbmodders extensions support: every
database at PHP 7.4 (MySQL 5.7 with coverage), plus PHP 8.0, 8.1 and 8.2
on MySQL 5.7, which were commented out. The PHP 7.3 job and a second
PHP 7.4 MySQL 5.7 job are dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bonelifer and others added 2 commits October 19, 2026 01:25
The tests now cover PHP 7.4 to 8.2, the range phpbbmodders extensions
support, and phpBB 3.3 itself needs PHP 7.2, so the declared PHP 7.1
minimum (composer.json, ext.php's enable check and the README) is raised to 7.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The extension has no PHPUnit tests, so the MySQL, PostgreSQL, SQLite and
MSSQL jobs only checked that phpBB installs, and on PHP 8 they fail
because PHPUnit 9 stops when the tests folder is missing. The basic
checks job (code sniffer, EPV, image and executable-file checks) stays.
Add database jobs back if tests are written.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer bonelifer changed the title Run the tests on Ubuntu 22.04 Get CI running again Oct 19, 2026
@bonelifer
bonelifer merged commit 071b489 into master Oct 19, 2026
1 check passed
@bonelifer
bonelifer deleted the runner-image branch October 19, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant