Repository navigation
Retake the screenshots with the shared tool, and show the whole ACP pages - #2
Merged
Merged
Conversation
…ages The twelve gallery screenshots came from one-off scripts. The Configuration page was cut off at the window height and had no Recent changes feed setting. They are now taken by phpbb-release-tools' screenshots.py, with the two ACP pages in full, and the captions match them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The ACP Configuration screenshot stopped at "Sorting order", with the Submit button and everything below it missing. It also predated the Recent changes feed setting from #57. This retakes all twelve gallery screenshots with the shared tool and updates the captions.
What changes
docs/images/screenshots/are retaken byphpbb-test-board/screenshots.pyfrom phpbb-release-tools. The two ACP pages are full-page.The main README's four thumbnails still fit at width 440.
Testing
Claude ran the tool and looked at each of the twelve images. Only images and the gallery README changed. The retake command refers to the Knowledge Base entry added in phpbbmodders/phpbb-release-tools#18, which should be merged first.
Investigated and written by Claude on behalf of William Jacoby (bonelifer).