Repository navigation
Add readable flag URLs and validation fixes for 2.4.5-dev - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Country member URLs currently require numeric flag IDs. This adds case-insensitive country codes, including
/flags/USA,/flags/CA, and/flags/MX, while preserving numeric links and readable pagination.The validation repairs move new uploads into board storage, prevent request-controlled file deletion, preserve bundled/shared images, handle empty flag lists safely, align member counts, invalidate dependent caches, and translate ACP errors. The candidate version is
2.4.5-dev; the existing phpBB 3.3.19/PHP 8.3.36 minimum is preserved and reflected in metadata, documentation and CI.Codex verified 67 standalone regression checks, EPV with zero findings, PHP syntax, Twig compilation, runtime/database checks and browser flows on phpBB 3.3.19/PHP 8.4.26/SQLite. The committed ZIP passed fresh EPV and isolated-board runtime checks. GitHub CI passed.
Investigated and written by Codex on behalf of William Jacoby (bonelifer).