Repository navigation
Show a lock beside protected articles in the wiki's lists - #80
Merged
Merged
Conversation
The overview, Recent changes, wiki search results, the board-search wiki block and the category pages put a lock icon beside a protected article's title; hovering it, or a screen reader, says which groups may edit it. The protected articles are read once per page. The note's string moves to the language file every page loads, so the board search can use it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Protect article was only in the version history's moderator controls. The article page now has a padlock button beside Edit, Versions and Watch for members who may protect: open when the article is not protected, closed and red when it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protection (#78) showed only on the article itself. Now the overview, Recent changes, the wiki search results, the wiki block in phpBB's search and the category pages put a lock beside a protected article's title. Hovering it, or a screen reader, says which groups may edit it. The protected articles are read once per page (
protection::list_label()), not once per row. The note's string moves tolink.php, which every page loads, so phpBB's own search page can use it.The article page also gets a Protect button (a padlock beside Edit, Versions and Watch) for members who may protect, so it's no longer only in the version history's moderator controls. It shows an open padlock when the article isn't protected, and a closed red one ("Protected: change who may edit") when it is.
Screenshots:
wiki-protected-article.pngis retaken to show the Protect button, andwiki-protected-list.pngshows the lock in Recent changes.Claude tested it:
Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code