Skip to content

Show a lock beside protected articles in the wiki's lists - #80

Merged
bonelifer merged 4 commits into
mainfrom
protected-list-cue
Oct 15, 2026
Merged

bonelifer merged 4 commits into
mainfrom
protected-list-cue

Conversation

@bonelifer

@bonelifer bonelifer commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Protection (#78) showed only on the article itself. Now the overview, Recent changes, the wiki search results, the wiki block in phpBB's search and the category pages put a lock beside a protected article's title. Hovering it, or a screen reader, says which groups may edit it. The protected articles are read once per page (protection::list_label()), not once per row. The note's string moves to link.php, which every page loads, so phpBB's own search page can use it.

The article page also gets a Protect button (a padlock beside Edit, Versions and Watch) for members who may protect, so it's no longer only in the version history's moderator controls. It shows an open padlock when the article isn't protected, and a closed red one ("Protected: change who may edit") when it is.

Screenshots: wiki-protected-article.png is retaken to show the Protect button, and wiki-protected-list.png shows the lock in Recent changes.

Claude tested it:

  • Unit tests on phpBB 3.3 and master, with a database test for the labels: groups A to Z, and a change showing straight away.
  • On the seed-forum 3.3 board, with two articles protected for different groups: the lock and its text on the overview, Recent changes, a category page, the categories list, the wiki search and the board-search block. The search index had to be built first, as the seed fixtures leave it empty.
  • The Protect button on the article page: open padlock, then the Protect page, then a closed red padlock once saved; no button for guests.
  • On the seed-forum 4.0 board: the overview and Recent changes.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

🤖 Generated with Claude Code

bonelifer and others added 4 commits October 14, 2026 22:06
The overview, Recent changes, wiki search results, the board-search wiki
block and the category pages put a lock icon beside a protected article's
title; hovering it, or a screen reader, says which groups may edit it.
The protected articles are read once per page. The note's string moves to
the language file every page loads, so the board search can use it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Protect article was only in the version history's moderator controls. The
article page now has a padlock button beside Edit, Versions and Watch for
members who may protect: open when the article is not protected, closed
and red when it is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer
bonelifer merged commit c445107 into main Oct 15, 2026
58 checks passed
@bonelifer
bonelifer deleted the protected-list-cue branch October 15, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant