Repository navigation
Read the clock once in the edit lock's start-time test - #83
Merged
Merged
Conversation
The test compared a time read when the row was inserted with time() read again at the check, so it failed when a second passed in between, as it did on a slow SQL Server runner. assertSame takes no tolerance, so the extra argument meant to allow for that did nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit_lock_test::test_taking_again_keeps_when_the_editor_started(#77) read the clock once when inserting the row and again when checking it, so it failed whenever a second passed in between. That happened on the SQL Server jobs of #82:1792037280 is identical to 1792037281. The extra argument meant to allow for it did nothing, asassertSametakes no tolerance. The test now reads the clock once and compares with that.Claude ran the unit tests on phpBB 3.3: all 331 pass.
Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code