Repository navigation
Let template calls nest deeper, set from the ACP - #89
Merged
Merged
Conversation
Template calls written in an article, and parameter defaults, may hold other calls 8 levels deep (it was 3, and 1 for defaults). Admins can set it from 3 to 20 under Extensions > Wiki > Settings. Saved articles are reparsed by a new cron task, a batch at a time on ordinary page views, after the update and after each change of the setting: a reparse during the migration would run without the wiki's listeners and strip every article's wiki markup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A template call written in an article, and a parameter's default value (
{{{name|...}}}), may now hold other calls 8 levels deep. It was 3 for calls and 1 for defaults. Template nesting depth under Extensions > Wiki > Settings changes it, from 3 to 20. Deeper calls show as written.Saved articles need reparsing to follow a new depth. A new cron task does that 50 articles at a time on ordinary page views, after this update and after each change of the setting. The settings page shows a note while it is running. When it finishes, the category memberships are worked out again, since a call that is now read (or no longer read) can add or drop a category.
The reparse can't run in the migration: the wiki's listeners aren't loaded while the extension is being enabled, so a reparse there would turn every article's headings and templates into plain text. The migration only queues it. This update also gets the call forms added in #87 (
{{formatnum:}},{{#rel2abs:}}and others) reparsed in existing articles. The README's older "run the reparser after upgrading" notes now point to the background reparse.Testing:
Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code