Repository navigation
Run EPV through the organization's strict EPV workflow - #2
Merged
Merged
Conversation
EPV exits 0 on Error findings, so they never failed this workflow, and pointing it at the extension folder gave a false "Packaging structure" error. EPV now runs in an epv job that calls phpbbmodders/.github's reusable EPV workflow (v1), which fails on any Fatal or Error finding not listed in .github/epv-allowed.txt. This extension has none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches this extension's EPV (Extension Pre Validator) check to the organization's strict EPV workflow,
phpbbmodders/.github/.github/workflows/epv.yml@v1(phpbbmodders/.github#2), as piloted in phpbbmodders/contactadmin#46.Why
phpBB/ext/instead..github/epv-allowed.txt.Changes
tests.yml: the "Setup EPV" and "Run EPV" steps and theEPVsetting are removed from the basic-checks job; its other checks and its check names are unchanged.epvjob calling the shared workflow for phpBB 3.3.x.Testing
Claude ran EPV (
phpbb/epvdev-master) locally on this extension's default branch, pointed at the folder containingrmcgirr83/separateusersandbots. It reports no Fatal or Error findings, so this extension needs no.github/epv-allowed.txt. The converted workflow parses, has theepvjob, and no longer runs EPV the old way. This PR's CI is the first run of the new job here.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code