Skip to content

Initial commit#3

Open
zloyuser wants to merge 1 commit into
masterfrom
pr
Open

Initial commit#3
zloyuser wants to merge 1 commit into
masterfrom
pr

Conversation

@zloyuser

@zloyuser zloyuser commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

@pronskiy

pronskiy commented Aug 6, 2019

Copy link
Copy Markdown

@wbars, could you help review please?

@wbars wbars self-requested a review August 6, 2019 11:09
@wbars

wbars commented Aug 17, 2019

Copy link
Copy Markdown
Collaborator

@zloyuser Hey! Just looked in the last master and don't quite get the idea of the plugin? Could you please give quick overview and specifically actual goal of the RedocServer? As far as I can see right now we only attach documents to the memory storage, but do no fetching - how this is supposed to be used? Aksing because just caching Documents can be dangerous because of memory leaks - better to fetch them in lazy manner since they will be cached by the platform. (see com.intellij.openapi.fileEditor.impl.FileDocumentManagerImpl#getDocument)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants