Report impossible class_exists/interface_exists/trait_exists/enum_exists#5754
Open
janedbal wants to merge 2 commits into
Open
Report impossible class_exists/interface_exists/trait_exists/enum_exists#5754janedbal wants to merge 2 commits into
janedbal wants to merge 2 commits into
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x. |
janedbal
force-pushed
the
struct-exists-impossibility
branch
from
3dc802f to
480fc5b
Compare
janedbal
force-pushed
the
struct-exists-impossibility
branch
from
480fc5b to
95f21da
Compare
Detect via reflection when the constant-string argument names a struct of the wrong kind (e.g. class_exists() on an interface name) and narrow the argument to never in the truthy context. Drop the ImpossibleCheckTypeHelper bailout for these four functions so the rule can pick up the impossibility, while still suppressing "always true" since runtime autoload can fail. Closes phpstan/phpstan#14683
janedbal
force-pushed
the
struct-exists-impossibility
branch
from
95f21da to
d04d50c
Compare
Collaborator
|
This pull request has been marked as ready for review. |
| $argsCount = count($args); | ||
| if ($node->name instanceof Node\Name) { | ||
| $functionName = strtolower((string) $node->name); | ||
| if (in_array($functionName, [ |
Contributor
There was a problem hiding this comment.
Given the fact this condition is now useless for 200 lines of code, I feel like it would be better moving the onlyReportFalse declaration.
This way we have
if ($node instanceof FuncCall) {
// specific logic which could be moved into a private or a dedicated service
}
$onlyReportFalse = ...;
// genericLogic
Maybe one day the
$onlyReportFalse = ...;
will become a
$onlyReportValue = // true/false/null
WDYT @staabm ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect via reflection when the constant-string argument names a struct of the wrong kind (e.g. class_exists() on an interface name) and narrow the argument to never in the truthy context. Drop the ImpossibleCheckTypeHelper bailout for these four functions so the rule can pick up the impossibility, while still suppressing "always true" since runtime autoload can fail.
Closes phpstan/phpstan#14683