-
Notifications
You must be signed in to change notification settings - Fork 575
Narrow division to int when modulo is known to be zero #5757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
staabm
merged 4 commits into
phpstan:2.1.x
from
phpstan-bot:create-pull-request/patch-uzkbeoe
May 26, 2026
+76
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c67de60
Preserve `BenevolentUnionType` for `IntegerRangeType` division result…
VincentLanglet 9024135
Narrow division to int when modulo is known to be zero
phpstan-bot ebf4d35
Add rule test for bug-9724 to prove the fix resolves the reported error
phpstan-bot c865717
Update bug-9724.php
staabm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace Bug9724; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| class HelloWorld | ||
| { | ||
| public function thisWorks(?int $limit, int $offset = 0): void | ||
| { | ||
| if ($limit && 0 === ($offset % $limit)) { | ||
| assertType('int', $offset / $limit); | ||
| assertType('int', ($offset / $limit) + 1); | ||
| } | ||
| } | ||
|
|
||
| public function thisDoesntWork(?int $limit, int $offset = 0): void | ||
| { | ||
| if ($limit && $offset && (0 === ($offset % $limit))) { | ||
| assertType('int<min, -1>|int<1, max>', $offset / $limit); | ||
| assertType('int<min, 0>|int<2, max>', ($offset / $limit) + 1); | ||
| } | ||
| } | ||
|
|
||
| /** @param int<-2, 2> $offsetRange */ | ||
| public function withRange(int $limit, int $offset, int $offsetRange): void | ||
| { | ||
| if ($limit) { | ||
| assertType('(float|int)', $offset / $limit); | ||
| assertType('float|int<-2, 2>', $offsetRange / $limit); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace Bug9724Rule; | ||
|
|
||
| class HelloWorld | ||
| { | ||
| private function expectInt(int $page): void | ||
| { | ||
| } | ||
|
|
||
| public function originalIssue(?int $limit, int $offset = 0): void | ||
| { | ||
| if ($limit && $offset && (0 === ($offset % $limit))) { | ||
| $this->expectInt(($offset / $limit) + 1); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.