Reject strict mixed when a template type is expected - #6416
Open
klimick wants to merge 1 commit into
Open
Conversation
Author
|
This PR makes PHPStan report an error for code like this: /**
* @phpstan-template TValue
*/
final class NonThreadSafeValue extends ThreadSafe
{
/**
* @phpstan-return TValue
*
* ERROR: Method NonThreadSafeValue::deserialize() should return TValue but returns mixed.
*/
public function deserialize(): mixed
{
return igbinary_unserialize($this->variable);
}
}This is technically correct because P.S. I noticed this while investigating the failed PMMP integration job in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At level 9 and above, passing explicitly typed
mixedtocallable(A): Ashould produce an error because the value is not guaranteed to matchA.This change adds that diagnostic.
Below level 9, passing
mixedtocallable(A): Ais allowed. This behavior remains unchanged.Closes phpstan/phpstan#11935