Skip to content

Report calls to strtr(), str_replace() and other replace functions that cannot change their subject #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phpstan-bot wants to merge 1 commit into
base: 2.2.x
Choose a base branch
from
Open

Report calls to strtr(), str_replace() and other replace functions that cannot change their subject #6423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conf/bleedingEdge.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ parameters:
switchConditionAlwaysFalse: true
checkImportedClassNameCase: true
sortWithoutEffect: true
stringReplaceWithoutEffect: true
8 changes: 8 additions & 0 deletions conf/config.level4.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ conditionalTags:
phpstan.rules.rule: %featureToggles.finiteTypesInHaystack%
PHPStan\Rules\Comparison\SwitchConditionRule:
phpstan.rules.rule: %featureToggles.switchConditionAlwaysFalse%
PHPStan\Rules\Functions\StringReplaceWithoutEffectRule:
phpstan.rules.rule: %featureToggles.stringReplaceWithoutEffect%

parameters:
checkAdvancedIsset: true
Expand Down Expand Up @@ -49,3 +51,9 @@ services:
class: PHPStan\Rules\Comparison\SwitchConditionRule
arguments:
treatPhpDocTypesAsCertain: %treatPhpDocTypesAsCertain%

-
class: PHPStan\Rules\Functions\StringReplaceWithoutEffectRule
arguments:
treatPhpDocTypesAsCertain: %treatPhpDocTypesAsCertain%
treatPhpDocTypesAsCertainTip: %tips.treatPhpDocTypesAsCertain%
1 change: 1 addition & 0 deletions conf/config.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ parameters:
switchConditionAlwaysFalse: false
checkImportedClassNameCase: false
sortWithoutEffect: false
stringReplaceWithoutEffect: false
fileExtensions:
- php
checkAdvancedIsset: false
Expand Down
1 change: 1 addition & 0 deletions conf/parametersSchema.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ parametersSchema:
switchConditionAlwaysFalse: bool()
checkImportedClassNameCase: bool()
sortWithoutEffect: bool()
stringReplaceWithoutEffect: bool()
])
fileExtensions: listOf(string())
checkAdvancedIsset: bool()
Expand Down
Loading
Loading