fix(API): Repo Sync schema fixes #STRINGS-1074#748
Merged
Conversation
theSoenke
approved these changes
Dec 20, 2024
Collaborator
theSoenke
left a comment
theSoenke
left a comment
There was a problem hiding this comment.
Thanks for fixing it. Looks good
Contributor
|
Ja, I think it makes sense to me, I was trying to follow the previous patterns, but it looks good :) |
This was referenced Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @horstmannmat, I changed slightly your PR #747 by extracting "Repo Sync Events" to a separate section (IMO it's more RESTful that way and makes future extending of the events API a bit easier).
Would you mind telling me what you think, would that work for you?
cc @theSoenke