fix: replace undefined cutoff with start/end range in hourly filter#116
Open
q0821 wants to merge 1 commit into
Open
fix: replace undefined cutoff with start/end range in hourly filter#116q0821 wants to merge 1 commit into
q0821 wants to merge 1 commit into
Conversation
The hourly chart filter referenced an undefined `cutoff` variable left over from the range-bounds refactor, throwing a ReferenceError that broke dashboard rendering. Switch to the same `start`/`end` bounds the daily and session filters use, which also fixes a silent data-mismatch where the hourly chart ignored upper bounds (e.g. prev-month, week).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceError: cutoff is not definedatdashboard.py:622(line 745 in source), breakingapplyFilter()and stopping the page from rendering wheneverloadData()fired.{ start, end }fromgetRangeBounds(), but the hourly filter still referenced the oldcutoffvariable.start/endbounds the sibling filters use. As a side effect this also fixes a silent data-mismatch: under the broken code the(!cutoff || ...)short-circuit was always truthy, so the hourly chart was rendering the full timeline instead of the selected range — meaning the "Average Hourly Distribution" chart never honored upper bounds likeprev-month,month, orweek.Repro (before fix)
Test plan
week,month,prev-month,7d,30d,90d,all) — hourly chart updates in sync with the daily / model / project charts.grep -n cutoff dashboard.pyreturns no matches.