Skip to content

Release workflowが登録済みの署名設定を参照できるようにする #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piaro merged 1 commit into from
Aug 10, 2026
Merged

Release workflowが登録済みの署名設定を参照できるようにする #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
ADF_RELEASE_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX: ${{ vars.ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX }}
ADF_RELEASE_SOURCE_ID: ${{ vars.ADF_RELEASE_SOURCE_ID }}
ADF_RELEASE_SIGNER_KEY_ID: ${{ vars.ADF_RELEASE_SIGNER_KEY_ID }}
ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX: ${{ vars.AGENTIC_RELEASE_SIGNING_PUBLIC_KEY_HEX }}
ADF_RELEASE_SOURCE_ID: ${{ vars.AGENTIC_RELEASE_SOURCE_ID }}
ADF_RELEASE_SIGNER_KEY_ID: ${{ vars.AGENTIC_RELEASE_SIGNER_KEY_ID }}
ADF_RELEASE_TAG: ${{ inputs.release_tag }}
ADF_RELEASE_REQUIRE_ATTESTATIONS: "1"

Expand Down Expand Up @@ -106,9 +106,9 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
ADF_RELEASE_CANDIDATE_RUN_ID: ${{ inputs.candidate_run_id }}
ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX: ${{ vars.ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX }}
ADF_RELEASE_SOURCE_ID: ${{ vars.ADF_RELEASE_SOURCE_ID }}
ADF_RELEASE_SIGNER_KEY_ID: ${{ vars.ADF_RELEASE_SIGNER_KEY_ID }}
ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX: ${{ vars.AGENTIC_RELEASE_SIGNING_PUBLIC_KEY_HEX }}
ADF_RELEASE_SOURCE_ID: ${{ vars.AGENTIC_RELEASE_SOURCE_ID }}
ADF_RELEASE_SIGNER_KEY_ID: ${{ vars.AGENTIC_RELEASE_SIGNER_KEY_ID }}
ADF_RELEASE_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
ADF_RELEASE_REQUIRE_ATTESTATIONS: "1"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
contents: read
id-token: write
env:
ADF_RELEASE_SIGNING_KEY_HEX: ${{ secrets.ADF_RELEASE_SIGNING_KEY_HEX }}
ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX: ${{ vars.ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX }}
ADF_RELEASE_SIGNING_KEY_HEX: ${{ secrets.AGENTIC_RELEASE_SIGNING_KEY_HEX }}
ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX: ${{ vars.AGENTIC_RELEASE_SIGNING_PUBLIC_KEY_HEX }}
ADF_RELEASE_SOURCE_ID: ${{ inputs.source_id }}
ADF_RELEASE_SIGNER_KEY_ID: ${{ inputs.signer_key_id }}
ADF_RELEASE_OUTPUT_DIR: ${{ github.workspace }}/dist/framework
Expand Down
16 changes: 8 additions & 8 deletions docs/publishing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ step, or from a password manager, avoids that.

| Where | Name | Value |
|---|---|---|
| Secret | `ADF_RELEASE_SIGNING_KEY_HEX` | the seed |
| Variable | `ADF_RELEASE_SIGNING_PUBLIC_KEY_HEX` | the public key |
| Variable | `ADF_RELEASE_SOURCE_ID` | the name releases are signed as coming from, for example `remote:official` |
| Variable | `ADF_RELEASE_SIGNER_KEY_ID` | the key's identifier, for example `framework.release.2026-08` |

Both names are recorded in the framework lock and the trust store and compared
as exact strings, so changing either one later breaks projects that already
pinned them. Choose them once.
| Secret | `AGENTIC_RELEASE_SIGNING_KEY_HEX` | the seed |
| Variable | `AGENTIC_RELEASE_SIGNING_PUBLIC_KEY_HEX` | the public key |
| Variable | `AGENTIC_RELEASE_SOURCE_ID` | the name releases are signed as coming from, for example `remote:official` |
| Variable | `AGENTIC_RELEASE_SIGNER_KEY_ID` | the key's identifier, for example `framework.release.2026-08` |

The source ID and signer key ID are recorded in the framework lock and trust
store and compared as exact strings. Changing either one later breaks projects
that already pinned them, so choose them once.

The key identifier should distinguish this key from the next one, because
rotation means both exist in the trust store at the same time. A date or a
Expand Down
Loading