Repository navigation
同じデータ保存先に対する未分類処理を確認可能にする - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
書き込みとして検出されたデータ保存先に、読み取りなど未分類の処理が併存する場合も、Repository Observationの作成時に確認・分類できるようにします。
背景
現在は書き込み処理だけが確認候補に入り、同じ保存先に対する未分類の読み取り処理は候補に出ません。一方、検証時には読み取り処理の分類が必要なため、利用者が妥当な観測記録を作れない状態でした。polls-betaの移行準備で、
insertとselectを同じ保存先に対して使う箇所から確認しました。変更内容
確認結果
cargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo test --lockedsh scripts/tests/test-rust.sh