Defer contract health until after impact assessment - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更結果
影響評価待ちのChangeでは、
adf nextとadf explainがリポジトリ全体のContract検証状態を計算せず、影響評価を次の作業として返すようにしました。POLLSの実データでは、修正前に27秒以上完了しなかった処理が次の時間で完了しました。
adf next: 2.86秒adf explain: 2.63秒背景
Contract検証状態の生成は、全ChangeのResultとEvidenceを読み込み、スキーマ検証、ハッシュ計算、条項ごとの履歴走査を行います。影響評価が未提出の場合、Kernelはこの情報を使わずに次の作業を決定できますが、従来は先に全件計算していました。
主な変更
nextとexplainでContract検証状態の生成を必要になるまで延期確認結果
cargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo test --lockedsh scripts/tests/test-rust.shnextとexplainを実測後続作業
Result内の重複参照の共通化、用途別の索引、ハッシュの再利用、既存データ移行は本PRに含めません。