Skip to content

Fix repeated risk-signal reviews after successful submission - #28

Merged
piaro merged 1 commit into
mainfrom
fix/current-candidate-reviews
Sep 9, 2026
Merged

piaro merged 1 commit into
mainfrom
fix/current-candidate-reviews

Conversation

@piaro

@piaro piaro commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Problem

Submitting a refreshed risk-signal review could succeed while the next action requested the same review again. Results are sorted by content-derived IDs, and an older non-applicability review could overwrite a current one solely because its ID sorted later.

Change

Select candidate reviews using current evidence before resolving ties, and share the selection across the kernel, explanations, and challenge context. Confirmation remains binding across evidence changes and takes precedence over conflicting non-applicability. Preserve independent challenge and reopen non-applicability when its evidence changes.

Update the CLI/MCP output schema descriptions, Analyst skill, and English and Japanese documentation.

Validation

  • Added a seven-candidate regression that fails before the fix and passes afterward, including reversed Result order and subsequent evidence changes.
  • Added conflicting-review coverage and a CLI/MCP integration test across process restarts.
  • Passed cargo fmt --check, cargo clippy --all-targets --locked -- -D warnings, cargo test --locked, and sh scripts/tests/test-rust.sh.

@piaro
piaro merged commit a134972 into main Sep 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant