Repository navigation
Fix repeated risk-signal reviews after successful submission - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Submitting a refreshed risk-signal review could succeed while the next action requested the same review again. Results are sorted by content-derived IDs, and an older non-applicability review could overwrite a current one solely because its ID sorted later.
Change
Select candidate reviews using current evidence before resolving ties, and share the selection across the kernel, explanations, and challenge context. Confirmation remains binding across evidence changes and takes precedence over conflicting non-applicability. Preserve independent challenge and reopen non-applicability when its evidence changes.
Update the CLI/MCP output schema descriptions, Analyst skill, and English and Japanese documentation.
Validation
cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,cargo test --locked, andsh scripts/tests/test-rust.sh.