This repository was archived by the owner on Sep 4, 2026. It is now read-only.
fix(macos): keep traffic lights centered through zoom and fullscreen - #403
Merged
Conversation
ElbertePlinio
force-pushed
the
fix/402-traffic-light-alignment
branch
from
July 31, 2026 20:15
66dbc12 to
a073f49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #402
What changed
trafficLightPositionoverride with native macOS positioning driven by window-level AppKit notifications.NSWindowis recreated.Why
AppKit can reset titlebar container/button frames during resize and fullscreen layout. The previous PR implementation observed replaceable titlebar views and raced AppKit's final layout, so it could become stale and briefly show the default control position during fullscreen exit. The replacement owns placement from the stable
NSWindowlifecycle instead.Validated
left=13 center=23both initially and after fullscreen/resizing.bun run buildcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --locked --all-targetsrustc -D warningscompile for cfg-gated helpersNotes
Local VRT completed 51 functional tests; 34 screenshot assertions could not compare because this checkout has no Darwin baselines, as documented by the repository. Generated local baselines were removed. This change does not modify web layout.
The superseded implementation remains available at
backup/pr-403-observer-attempt-20260731.