feat(review-tutor): add the Structure connections list - #71
Merged
Conversation
17 tasks
ElbertePlinio
force-pushed
the
feat/review-tutor-structure-list
branch
2 times, most recently
from
August 24, 2026 22:18
ad8f897 to
616dd86
Compare
Member
Author
|
Ready for human review at |
This was referenced Aug 24, 2026
ElbertePlinio
changed the base branch from
feat/review-tutor-structure-core
to
main
August 25, 2026 19:09
ElbertePlinio
force-pushed
the
feat/review-tutor-structure-list
branch
from
August 25, 2026 19:12
616dd86 to
060055c
Compare
Add a Diff | Structure | Learning log peer view that lists changed files and their evidence-backed connections from the structure endpoint, discloses partial analysis, and opens the exact diff line from any evidence row. List mode is the keyboard, screen-reader, mobile, and high-zoom baseline.
ElbertePlinio
force-pushed
the
feat/review-tutor-structure-list
branch
from
August 25, 2026 19:14
060055c to
4bf0db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #62 — PR 2 of 4 (accessible Connections list). Stacked on #67; part of the batched Review Tutor chain.
What changed
Diff | Structure | Learning logpeer view over the same input snapshot. Structure fetchesGET /api/structureonce per input (refetches after a source switch), shows the comparison line (index → working treeetc.), one partial-analysis notice with adetailsreasons list when the snapshot is partial or truncated, then file groups (path, status chip, ±counts, rename provenance, or the exact 'no import data' reason) with connection rows (target, kind chip,typechip, status chip). Selecting a row expands its evidence lines; Open in Diff switches to the Diff view, scrolls the exact line into view, and moves focus to it.aria-labelledby, rows as buttons witharia-expanded/aria-controls, status in text not color alone, ≥44px targets on touch, no new colors or motion.branding-visual/DESIGN-PRINCIPLES.md: status left rules were removed as duplicates of the chips, and empty connection lists / a mobile sticky-offset band were eliminated (nothing empty on screen).Tested
bun run check: 474 passed | 25 skipped, 81.51% statements.Not tested
Local review: serious user-facing class — three independent reviewers (correctness, tests/conformance/KISS, UI/accessibility with rendered inspection). Human gate: merge only on Elberte's authorization.