Skip to content

feat(review-tutor): animate the configuration rail and drop diff actions on neighbour evidence - #74

Merged
ElbertePlinio merged 7 commits into
mainfrom
feat/review-tutor-structure-polish
Aug 25, 2026
Merged

feat(review-tutor): animate the configuration rail and drop diff actions on neighbour evidence#74
ElbertePlinio merged 7 commits into
mainfrom
feat/review-tutor-structure-polish

Conversation

@ElbertePlinio

Copy link
Copy Markdown
Member

Refs #62 — PR 5 of the Structure view chain, stacked on #73. Polish from Elberte's live test of #73.

What changed

  • The configuration rail collapse/expand animates (grid-template-columns 200ms). Reduced motion keeps it instant via the existing global rule.
  • Evidence rows whose line lives in an unchanged neighbour (CONTEXT file) no longer show Ask the tutor / Open in Diff. Those buttons had nothing to land on and failed with only a screen-reader announcement; the evidence text stays.

Tested

  • vitest run packages/review-tutor/test — 263 passed; typecheck clean.
  • New test: neighbour evidence has no actions, changed-file evidence keeps them; existing "outside the diff" test updated to the new contract.
  • Live: Pi session on 0fca354...HEAD with neighbours on.

Not tested

  • No automated visual capture of the transition; checked in a real browser only.

Risk class: standard (one Sol correctness reviewer + KISS gate).

@ElbertePlinio
ElbertePlinio changed the base branch from feat/review-tutor-structure-languages to main August 25, 2026 19:18
@ElbertePlinio
ElbertePlinio force-pushed the feat/review-tutor-structure-polish branch from 83c782a to 253704b Compare August 25, 2026 19:21
@ElbertePlinio
ElbertePlinio merged commit a8fd61b into main Aug 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant