feat(review-tutor): always register the Claude Code and Codex connectors - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63 — enables the harness connectors and removes the
reviewTutorHarnessConnectorsflag in one step.Why one step
Review Tutor is private and installed from a checkout (
pi install <path>), somainis the build; a separate "enabled" commit would guard nothing between two merges. Elberte tested the flag-on build (identical code) before #76–#80 merged.What changed
createConnectorRegistryalways registers Pi, Claude Code, Codex (that order);src/flags.tsand theREVIEW_TUTOR_FLAGSswitch are gone.which/execFilestubs so discovery never spawns real binaries (PATH-shim proof: 0 calls across the suite).Tested
vitest run packages/review-tutor/test— 344 passed; package typecheck clean; rootbun run checkgreen.claude/codexduring the suite — 0 invocations.Not tested
Risk class: standard (one reviewer).