Skip to content

feat(review-tutor): always register the Claude Code and Codex connectors - #81

Merged
ElbertePlinio merged 1 commit into
mainfrom
chore/review-tutor-remove-connector-flag
Aug 26, 2026
Merged

feat(review-tutor): always register the Claude Code and Codex connectors#81
ElbertePlinio merged 1 commit into
mainfrom
chore/review-tutor-remove-connector-flag

Conversation

@ElbertePlinio

Copy link
Copy Markdown
Member

Closes #63 — enables the harness connectors and removes the reviewTutorHarnessConnectors flag in one step.

Why one step

Review Tutor is private and installed from a checkout (pi install <path>), so main is the build; a separate "enabled" commit would guard nothing between two merges. Elberte tested the flag-on build (identical code) before #76#80 merged.

What changed

  • createConnectorRegistry always registers Pi, Claude Code, Codex (that order); src/flags.ts and the REVIEW_TUTOR_FLAGS switch are gone.
  • A connector only appears in the Harness picker when its executable is found and supported at startup; the helper line explains the rest (unchanged behaviour, now unconditional).
  • Tests: flag on/off cases collapsed; every registry built in tests injects which/execFile stubs so discovery never spawns real binaries (PATH-shim proof: 0 calls across the suite).
  • README: flag paragraph replaced.

Tested

  • vitest run packages/review-tutor/test — 344 passed; package typecheck clean; root bun run check green.
  • PATH shim for claude/codex during the suite — 0 invocations.

Not tested

  • No new real-provider smoke (behaviour identical to the flag-on build Elberte tested on 2026-08-26).

Risk class: standard (one reviewer).

@ElbertePlinio
ElbertePlinio merged commit 4413a69 into main Aug 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add isolated Claude Code and Codex connectors to Review Tutor

1 participant