Skip to content

fix(pretty): coerce string offset and limit in readCall line range #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamxeph wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pretty): coerce string offset and limit in readCall line range #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ export function readCall(
args: { path?: string; offset?: number; limit?: number },
max: number = DEFAULT_CLIP,
): string {
const offset = args.offset ? Number(args.offset) : undefined;
const limit = args.limit ? Number(args.limit) : undefined;
const range =
args.offset || args.limit
? theme.fg("dim", ` · lines ${args.offset ?? 1}${args.limit ? `–${(args.offset ?? 1) + args.limit - 1}` : "+"}`)
offset || limit
? theme.fg("dim", ` · lines ${offset ?? 1}${limit ? `–${(offset ?? 1) + limit - 1}` : "+"}`)
: "";
return title(theme, "Read") + theme.fg("accent", compactPath(args.path ?? "", max)) + range;
}
Expand Down
13 changes: 13 additions & 0 deletions test/pretty.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@ test("readCall shows path and range", () => {
assert.equal(readCall(theme, { path: "src/a.ts" }), "Read src/a.ts");
assert.ok(readCall(theme, { path: "a", offset: 10, limit: 5 }).includes("lines 10–14"));
assert.ok(readCall(theme, { path: "a", offset: 3 }).includes("lines 3+"));
// LLMs may pass numeric arguments as strings at runtime
assert.ok(
readCall(theme, { path: "a", offset: "1" as unknown as number, limit: "2000" as unknown as number }).includes(
"lines 1–2000",
),
);
assert.ok(
readCall(theme, { path: "a", offset: "1046" as unknown as number, limit: "400" as unknown as number }).includes(
"lines 1046–1445",
),
);
assert.ok(readCall(theme, { path: "a", offset: "5" as unknown as number }).includes("lines 5+"));
assert.ok(readCall(theme, { path: "a", limit: "20" as unknown as number }).includes("lines 1–20"));
});

test("readSummary counts lines, flags truncation and failure", () => {
Expand Down