Backport: ci: updated github actions ci workflow#148
Open
Phillip9587 wants to merge 1 commit intopillarjs:1.xfrom
Open
Backport: ci: updated github actions ci workflow#148Phillip9587 wants to merge 1 commit intopillarjs:1.xfrom
Phillip9587 wants to merge 1 commit intopillarjs:1.xfrom
Conversation
Phillip9587
changed the title
wesleytodd
approved these changes
Mar 5, 2025
Member
|
I pushed it just to see if the CI was still failing and why, and it looks to me like the error we saw from a bad |
Member
|
Hm, we are on the 6.x line. Maybe something else is up? |
Member
|
Haha, every node version that failed failed with a different error. That is for sure messed up, and likely not at all related to this change or even the tests failing. While I see we are on the 6.x supertest I am still very suspicious of this failure. |
UlisesGascon
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #143