Skip to content

Fix error that occurred when the language file content ends with a se…#3

Open
rblmdst wants to merge 2 commits into
pillarsjs:masterfrom
rblmdst:fix_semicolon_error
Open

Fix error that occurred when the language file content ends with a se…#3
rblmdst wants to merge 2 commits into
pillarsjs:masterfrom
rblmdst:fix_semicolon_error

Conversation

@rblmdst

@rblmdst rblmdst commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

When the language file content ends with ; (that is a valid JS) for eg:

({
  sum: "The result of the operation {operation} is {result}",
  inbox: "You Have {mails} mensajes",
  hello: "Hi {firstname} {lastname}"
}); // semicolon

Instead of :

({
  sum: "The result of the operation {operation} is {result}",
  inbox: "You Have {mails} mensajes",
  hello: "Hi {firstname} {lastname}"
}) // no semicolon

Then the following error occurred :

  Line 6 > Unreachable ';' after 'return'.
         ...;})();...
  Line 6 > Unnecessary semicolon.
          ...;})();...

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me!

@rblmdst

rblmdst commented Jan 8, 2019

Copy link
Copy Markdown
Contributor Author

Greetings
Any updates about this PR ?

@rblmdst

rblmdst commented Oct 27, 2019

Copy link
Copy Markdown
Contributor Author

Hello,
This PR has over 1 year now 🤔 !! Is the project not be maintained anymore ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants