[Studio] Render the configuration editor from a configuration it is given - #691
Draft
markus-moser wants to merge 2 commits into
Draft
[Studio] Render the configuration editor from a configuration it is given#691markus-moser wants to merge 2 commits into
markus-moser wants to merge 2 commits into
Conversation
…iven The detail view both fetched the configuration and rendered it, so the tab tree could only ever show what the detail endpoint returned. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataImporterDetailViewboth fetched the configuration and rendered it, so the tab tree could only ever show what the detail endpoint returned for the current user.This splits the two.
DataImporterConfigEditorowns the form, the tabs anduseDetailView, over aconfigurationit is handed. The detail view keeps the RTK query, the permission derivation and the save mutation, and passes the toolbar in through a render prop, becauseisDirtyand the save handler only exist inside the form.No behaviour change: same tabs, same toolbar, same
BaseDetailViewprops.Gates
npm run check-typesnpm run lintVerified in the running app against the
car-importconfiguration — General, Data Setup (all five steps), Execution and Permissions all render as before, with no server errors.🤖 Generated with Claude Code