[Spike] Map between stored and form addressing of a configuration - #692
Draft
markus-moser wants to merge 1 commit into
Draft
[Spike] Map between stored and form addressing of a configuration#692markus-moser wants to merge 1 commit into
markus-moser wants to merge 1 commit into
Conversation
transformBackendToForm() flattens general.* and the mapping list is addressed by mappingId when stored but by index in the form, so a dotted address into the stored document does not name the same field in the editor. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Spike — for review of the approach, not for merge as it stands. Nothing consumes
ConfigurationPathMapperyet; it exists to settle a question before a review/diff surface is built on top of the configuration editor.transformBackendToForm()is not shape-preserving, so a dotted address into the stored configuration does not name the same field in the form. Two rules cover every divergence:general.active|description|group|nameare lifted to the form root.mappingIdin the stored document and by list index in the form.Everything else is the same path on both sides.
The tests document three findings that matter for anything diffing a configuration:
mappingIdis minted in the Studio form, so a configuration written before it, or by the console, carries none. Those rows are skipped rather than given a positional key, so a caller can tell the difference.Gates
🤖 Generated with Claude Code