[Studio UI] Align action labels with the add/new and delete/remove rules - #4043
[Studio UI] Align action labels with the add/new and delete/remove rules#4043idaiv wants to merge 4 commits into
Conversation
Applies the labelling rules from #645 to wording that still contradicted them, without touching casing — #4031 already settled that, and its Title Case for context menus is preserved. Add vs New. Eleven creation dialogs were labelled "Add new ..." or "Create new ...", using both verbs at once or one the ruleset does not define. The ruleset gives "New" for creating from scratch, in a modal included, so they now read "New object of type X", "New user", "New class definition" and so on. The icons already agreed with this — folder-plus, shield-plus and an add-user glyph that is a person with a plus — so the words were the only mismatch. Delete vs Remove. Five actions rendered a trash icon, called a delete endpoint and warned that the action cannot be undone, while their label said Remove: the site tree action, the folder tree action, both thumbnail transformation lists and the notification toolbar. Their tree-action siblings already read "Delete user" and "Delete role", so "Delete" is what matches both the icon and the neighbouring wording. The site dialog's confirmation text and confirm button, and the folder and user success messages, are aligned with it. Untouched: tags, crop and bulk-import removals, which genuinely leave the thing in the system, and "Create" on modal confirm buttons, which the ruleset does not cover and the codebase applies consistently. Also adds roles.remove-folder, user-management.remove-folder and their .text counterparts. Both folder-delete modals reference them, but they were missing from all seven locale files, so the dialog rendered the raw keys as its title and body. Refs #645 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Aligns creation and deletion labels with issue #645 across all supported locales.
Changes:
- Rewords creation and deletion actions.
- Adds missing folder-deletion translations.
- Uses “Delete” for site-confirmation actions.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
translations/studio.en.yaml |
Updates English labels and missing keys. |
translations/studio.de.yaml |
Updates German translations. |
translations/studio.es.yaml |
Updates Spanish translations. |
translations/studio.fr.yaml |
Updates French translations. |
translations/studio.it.yaml |
Updates Italian translations. |
translations/studio.no.yaml |
Updates Norwegian translations. |
translations/studio.sv.yaml |
Updates Swedish translations. |
assets/js/src/core/modules/document/actions/site/use-site-actions.tsx |
Changes site confirmation to “Delete.” |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🌐 Translations synced automaticallyThe key changes below were generated for all target languages, passed the Added (4):
Re-translated (English value changed) (8):
♻️ Existing translations kept (verify these)These keys changed in English but kept their existing translations — confirm they still fit the new English wording.
|
tree.actions.remove-folder is a tree context-menu item, so it keeps Title Case per #4031 — the verb change should not have altered casing, which the PR description itself said it would not. The Swedish site strings use "sajt", as its siblings use-as-site and edit-site already do; "webbplats" introduced a second term for the same noun. Swedish is the only locale where this drifted — every other one already matched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|



Changes in this pull request
Refs #645
Applies the labelling rules from #645 to wording that still contradicted them. Casing is untouched — #4031 already settled that, and its Title Case for context menus is preserved throughout.
Add/Create → New (11 keys)
Creation dialogs that used both verbs at once (
Add new ...) or one the ruleset does not define (Create new ...). The ruleset gives New for creating from scratch, "directly or in a modal".data-object.create-data-objectdata-object.create-variantuser-management.add-useruser-management.add-folderroles.add-roleroles.add-folderclass-definition.create-newfield-collection.create-newobject-brick.create-newselect-option.create-newfield-definitions.create-new-class-definitionThe icons already agreed with this —
folder-plus,shield-plus, and anadd-userglyph that is a person with a plus. A plus means New, so the words were the only mismatch.Remove → Delete (5 keys)
Each renders a trash icon, calls a delete endpoint, and warns the action cannot be undone, while the label said Remove.
document.site.remove-sitedocumentDeleteSite, "cannot be undone"tree.actions.remove-folderimage-thumbnails.transformations.removevideo-thumbnails.transformations.removenotifications.remove-alldeleteNotificationsForUser()Supporting strings in those same dialogs follow: the site confirmation now says permanently delete, its confirm button is
t(delete)instead oft(remove), and the folder/user success toasts say deleted.Bug: four keys missing from every locale
roles.remove-folder,user-management.remove-folderand both.textcounterparts are referenced by the folder-delete modals but were absent from all 7 locale files, so the dialog rendered the raw keys as its title and body. Added, worded to match the neighbouring user/role delete dialogs.Additional info
Deliberately unchanged
Createon modal confirm buttons — the ruleset covers trigger labels, not confirm buttons, and the codebase applies it consistently.tags.columns.actions,crop.remove,bulk-import.remove-file— these genuinely leave the thing in the system, so Remove is correct.Translations are derived from the existing strings rather than re-invented, and match each locales established
deleteterm (Löschen,Eliminar,Supprimer,Elimina,Slett,Ta bort). German also moves accusative → nominative once the verb drops (Neuen Benutzer hinzufügen→Neuer Benutzer), which a mechanical strip would have got wrong.Scope: 24 keys (20 reworded, 4 added) × 7 locales, plus one code line. Key parity is equal across locales.
Verification:
eslint✅ ·tsc --noEmit✅Not verified: no visual review of the changed labels in the running UI.