Re-Order Selected Tags (Drag and Drop Tags) - #4044
Open
lukemacausland wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes.
Adds drag-and-drop reordering for selected Data Object multiselect tags.
Changes:
- Adds sortable-tag rendering and drag sensors to
Select. - Enables sorting for static Data Object multiselects.
- Adds dragging cursor styles.
Assessment:
- The shared component is the correct boundary, but dynamic-option multiselects are missed.
- Reordering breaks Ant Design’s option callback contract.
- Remove actions conflict with drag listeners and lack localized accessibility text.
- No regression tests or sortable Storybook example were added.
- No existing API defaults are changed; no external documentation appears necessary.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
dynamic-type-object-data-abstract-select.tsx |
Enables sorting for static multiselect fields. |
select.tsx |
Adds the sortable API and DnD context. |
select.styles.ts |
Adds drag cursor styling. |
use-sortable-tags.ts |
Implements sensors and value reordering. |
sortable-tag.tsx |
Renders draggable, removable tags. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return | ||
| } | ||
|
|
||
| onChange?.(arrayMove(value, oldIndex, newIndex), []) |
| optionFilterProp={ hasHtmlLabels ? 'title' : 'label' } | ||
| options={ options } | ||
| showSearch | ||
| sortableTags={ props.multiSelect === true } |
Comment on lines
+58
to
+59
| { ...(isMaxTag ? {} : attributes) } | ||
| { ...(isMaxTag ? {} : listeners) } |
| minWidth?: number | keyof typeof sizeOptions | ||
| theme?: SelectTheme | ||
| loadingSkeleton?: boolean | ||
| sortableTags?: boolean |
| <span className="ant-select-selection-item-content">{label}</span> | ||
| {closable && ( | ||
| <span | ||
| aria-label="remove" |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
closes pimcore/platform-version#426
Additional info
Adds the ability to drag and drop selected tags in a list so that the user can re-order values.