[Field Definitions] Review mode for the editor: read-only settings, tree item decorator, form item annotations - #4085
Draft
markus-moser wants to merge 7 commits into
Draft
Conversation
…ree item decorator, form item annotations Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…nnotations Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…y for the annotation key Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes in this pull request
The field-definitions editor gains a review mode and two seams a consumer needs to render a proposed class definition next to its current one — without copying the editor:
readOnlyon the editor settings: the tree navigates but never rearranges (no drag & drop, no add / copy / paste / delete actions), the layout and general-settings forms render disabled, and Save, import/export and custom layouts stay out of the toolbar.useDetailUpdateMutationbecomes optional.decorateTreeItemon the editor settings: the last word on every layout-tree item before it renders — add a status class, wrap the title.FormAnnotationsProvider(@pimcore/studio-ui-bundle/components): everyForm.Itembelow it whose name is in the map renders with a status tint (added|changed|removed|moved) and an optional hint under the control. The form needs no change; the HOC sits innermost inForm.Item's chain, so the key is the resolved name path.EditorView,ItemsSidebar,ItemsTabs,ItemDetail,DetailSidebar,DetailContent,LayoutForm,GeneralSettingsForm) are exported from@pimcore/studio-ui-bundle/modules/field-definitions, so a consumer can compose its ownview.Tests:
form-annotations.test.tsx(HOC + key),sidebar.test.tsx(edit vs review vs decorator). Storybook: Components / Data Entry / Form / Annotations.Additional info
Gates:
check-typesclean, eslint clean, jest 616/616,build-sdkok.🤖 Generated with Claude Code