Skip to content

[Field Definitions] Review mode for the editor: read-only settings, tree item decorator, form item annotations - #4085

Draft
markus-moser wants to merge 7 commits into
2026.xfrom
feat/field-definitions-review-mode
Draft

[Field Definitions] Review mode for the editor: read-only settings, tree item decorator, form item annotations#4085
markus-moser wants to merge 7 commits into
2026.xfrom
feat/field-definitions-review-mode

Conversation

@markus-moser

Copy link
Copy Markdown
Contributor

Changes in this pull request

The field-definitions editor gains a review mode and two seams a consumer needs to render a proposed class definition next to its current one — without copying the editor:

  • readOnly on the editor settings: the tree navigates but never rearranges (no drag & drop, no add / copy / paste / delete actions), the layout and general-settings forms render disabled, and Save, import/export and custom layouts stay out of the toolbar. useDetailUpdateMutation becomes optional.
  • decorateTreeItem on the editor settings: the last word on every layout-tree item before it renders — add a status class, wrap the title.
  • FormAnnotationsProvider (@pimcore/studio-ui-bundle/components): every Form.Item below it whose name is in the map renders with a status tint (added | changed | removed | moved) and an optional hint under the control. The form needs no change; the HOC sits innermost in Form.Item's chain, so the key is the resolved name path.
  • The editor's inner components (EditorView, ItemsSidebar, ItemsTabs, ItemDetail, DetailSidebar, DetailContent, LayoutForm, GeneralSettingsForm) are exported from @pimcore/studio-ui-bundle/modules/field-definitions, so a consumer can compose its own view.

Tests: form-annotations.test.tsx (HOC + key), sidebar.test.tsx (edit vs review vs decorator). Storybook: Components / Data Entry / Form / Annotations.

Additional info

Gates: check-types clean, eslint clean, jest 616/616, build-sdk ok.

🤖 Generated with Claude Code

markus-moser and others added 7 commits September 7, 2026 09:37
…ree item decorator, form item annotations

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…nnotations

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…y for the annotation key

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant