[Web-to-Print Configuration] UI Improvements - #4089
Open
idaiv wants to merge 2 commits into
Open
Conversation
Closes #3500 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approved
The change is small, localized, and aligns the shared Toolbar spacing with the stated design requirement without introducing behavioral risk.
Pull request overview
Updates the shared Toolbar UI component to align button spacing with the Web-to-Print Configuration design spec (Issue #3500), improving consistency with other toolbars in the Studio UI.
Changes:
- Reduced the toolbar button gap from 16px to 8px in the
Toolbarcomponent.
File summaries
| File | Description |
|---|---|
| assets/js/src/core/components/toolbar/toolbar.tsx | Adjusts the internal Flex gap to 8px to match the design requirement for consistent button spacing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| align={ align } | ||
| className='w-full' | ||
| gap={ 16 } | ||
| gap={ 8 } |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3500
Changes
Button Toolbar gap (
toolbar.tsx)The
Toolbarcomponent's innerFlexhad a hardcodedgap={16}(16px). The design spec requires 8px between buttons to be consistent with other locations. Changed togap={8}.Test plan