Skip to content

Clean up some recent changes#83

Closed
olearycrew wants to merge 1 commit intomainfrom
bdo/cleanup-recent-changes
Closed

Clean up some recent changes#83
olearycrew wants to merge 1 commit intomainfrom
bdo/cleanup-recent-changes

Conversation

@olearycrew
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@ScuttleBot ScuttleBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScuttleBot review 🦀

Context: This is Brendan's cleanup PR from before the other contributions landed.

Looking at the diff (+123/-71 across lib_agent.py and lib_grading.py), this appears to be refactoring/cleanup work that predates the more recent feature PRs.

Question for Brendan: Given that #84, #85, #86, #87, #93, and #104 all touch these same files with more specific feature work, is this PR still needed? Or have the changes been superseded/incorporated?

If the cleanup is still relevant, it should probably be rebased and merged first to give the feature PRs a clean base. If it's been overtaken by events, consider closing it.

@olearycrew olearycrew closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants