fix(docs): update it-threat-detection.ipynb to SDK v8 #523
Conversation
- Update Pinecone SDK install from pinecone-client==3.1.0 to pinecone
- Update API key handling to use getpass fallback pattern
- Use pc.has_index() instead of pc.list_indexes().names()
- Add named keyword argument for create_index name parameter
- Remove outdated TensorFlow/Keras version pins
- Update stale documentation link
- Remove time-sensitive language ("recent academic work")
Resolves SDK-134
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- Fix import sorting (I001 errors) - Add missing metadata to execute_result outputs - Add missing name to stream outputs
CI Status NotesThe following CI checks are failing due to pre-existing issues with this notebook, not the SDK v8 update: Link Check Failure
Notebook Execution Failure
Checks That Pass
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Address Bugbot review: change `from keras.utils.np_utils import normalize` to `from tensorflow.keras.utils import normalize` since standalone keras was removed from dependencies.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| cli() |
There was a problem hiding this comment.
Unrelated ticket automation script accidentally included
High Severity
The file scripts/ticketbot.py appears to be accidentally committed in this PR. The PR is titled "fix(docs): update it-threat-detection.ipynb to SDK v8" and the description exclusively discusses notebook updates for Pinecone SDK v8. However, this 371-line script is a completely unrelated ticket automation tool that spawns Cursor agents to handle ticket processing. It has no connection to the Pinecone SDK or the notebook being updated and is not mentioned anywhere in the PR description or discussion.
Summary
pc.has_index()instead of deprecatedlist_indexes().names()patternRelated
Test plan
Note
Medium Risk
Mostly documentation/notebook updates, but adds a new
scripts/ticketbot.pyautomation CLI that spawns subprocess worker pools, manages git worktrees, and runs theagentcommand with retries—misconfiguration could impact local repos or CI runners.Overview
Notebook update: Refreshes
learn/security/it-threat-detection.ipynbto Pinecone Python SDK v8 usage (e.g.,pip install pinecone,getpassAPI key fallback,pc.has_index()), loosens dependency pins, and updates minor docs/formatting.New automation tooling: Adds
scripts/ticketbot.py, aclick-based CLI that orchestrates multiple worker pools (tb-pick-work,tb-iterate-prswith modulo sharding,tb-merge-ready) by creating per-workergit worktrees, invokingagentwith logging and exponential-backoff retries, and supporting graceful drain on SIGTERM/CTRL-C.Written by Cursor Bugbot for commit 6bcbb96. This will update automatically on new commits. Configure here.