WIP on threadpool impl of query_namespaces#405
Closed
jhamon wants to merge 4 commits intojhamon/grpc-asynciofrom
Closed
WIP on threadpool impl of query_namespaces#405jhamon wants to merge 4 commits intojhamon/grpc-asynciofrom
jhamon wants to merge 4 commits intojhamon/grpc-asynciofrom
Conversation
harsha2010
reviewed
Oct 25, 2024
| attempts = 0 | ||
| while attempts < retries: | ||
| try: | ||
| return func(*args, **kwargs) # Attempt to call __call_api |
There was a problem hiding this comment.
I'm not a python expert, but isn;t there some library that provides a decorator to retry functions? seems like this should be a solved problem
Collaborator
Author
There was a problem hiding this comment.
There's nothing in the standard library afaik, and I'm very hesitant to add third-party dependencies because of the overall dependency hell situation in python.
harsha2010
reviewed
Oct 25, 2024
| # aggregate them correctly. So we'll temporarily set topK to 2 for the | ||
| # subqueries, and then we'll take the topK=1 results from the aggregated | ||
| # results. | ||
| overall_topk = top_k if top_k is not None else 10 |
Collaborator
Author
There was a problem hiding this comment.
It's just a default value. Could be anything, but the API requires a value to be passed.
Collaborator
Author
|
Pursuing this in a different branch #409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I need a non-async interface providing a similar functionality as the
query_namespacescurrently implemented inGRPCIndexAsyncio.Solution
Background info:
multiprocessingThreadPool is currently setup during the instantiation ofIndex. The constructor takes a param for number ofpool_threadswith a default value of 1.async_req=True, the underlying (generated from openapi spec) code will execute the request usingpool.apply_async. The result of these calls is anApplyResult[QueryResult]. To get the results, from these we call.get()on theApplyResult.New
query_namespacesonIndex:querywithasync_req=TrueApplyResultsinto a results arrayQueryResultsAggregator, recently implemented and tested in [Feat] asyncio for grpc data interactions #398Todo:
Usage
Dev build for manual testing
pip install pinecone==6.0.0.dev3Type of Change
Test Plan
Describe specific steps for validating this change.