Phase 2A: Response Adapter Consolidation #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate duplicated parse_query_response and response transformation logic into a centralized pinecone/adapters module. This introduces: - adapt_query_response() - Convert OpenAPI QueryResponse to SDK type - adapt_upsert_response() - Convert OpenAPI UpsertResponse to SDK type - adapt_fetch_response() - Convert OpenAPI FetchResponse to SDK type The adapter functions replace 4+ copies of identical transformation logic that was scattered across index.py, index_asyncio.py, and resource modules. Original parse_query_response functions are preserved as thin wrappers for backward compatibility. Also adds: - Unit tests for all adapter functions (15 tests) - Test fixtures for OpenAPI response models Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Move UpsertResponseTransformer class from db_data/index.py and db_data/resources/sync/vector.py to the adapters module. This addresses the code review feedback about duplicated class definitions. Both files now import UpsertResponseTransformer from the centralized adapters module instead of defining their own copies. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The extract_response_metadata utility function is only used internally within response_adapters.py and should not be part of the public API surface. Removed it from __all__ exports in pinecone/adapters/__init__.py. Co-authored-by: Cursor <cursoragent@cursor.com>
jhamon
deleted the
jhamon/sdk-274-phase-2a-response-adapter-consolidation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pinecone/adapters/module for OpenAPI response transformationsparse_query_responsefunctions from 4+ files into singleadapt_query_response()adapt_upsert_response()andadapt_fetch_response()adaptersTest plan
Resolves: SDK-274
Made with Cursor
Note
Medium Risk
Touches core data-plane response transformation for
query,fetch, and async upsert results; behavior should be unchanged but any mismatch in adapter logic could affect returned dataclasses or response metadata across clients.Overview
Consolidates OpenAPI→SDK response parsing into a new
pinecone/adapterslayer. Addsadapt_query_response,adapt_fetch_response, andadapt_upsert_response, plus anUpsertResponseTransformerwrapper for asyncApplyResult.Updates sync/async index and vector resources to use these shared adapters and replaces duplicated parsing code, while keeping existing
parse_query_responseas deprecated pass-through wrappers for backward compatibility.Adds unit test coverage and new OpenAPI response fixtures to validate adapter behavior (namespace handling, usage, deprecated field cleanup, and response metadata extraction).
Written by Cursor Bugbot for commit 716b744. This will update automatically on new commits. Configure here.