Repository navigation
Separate source-day policy from native settlement - #248
Merged
Merged
Conversation
Keep native settlement and financial counter checks independent of source-day state. Preserve source preflight ordering and observe only committed rows through the three source coordinators, with native margin and physical-observation coverage.
luisleo526
marked this pull request as ready for review
September 13, 2026 02:46
luisleo526
added a commit
that referenced
this pull request
Sep 14, 2026
…commit view, FX curve (R4-B) (#251) * Freeze the epoch-14 native provider header closure from f736676 Track the exact 55-file include closure of the last engine_script_run_v14 commit (PR #250 squash f736676, tree c69421f) as a fixture, authenticated per file by size, SHA-256 and Git blob, before any epoch-15 edit begins. The preparation tool will build the real immutable source with each profile's compiler and configuration; nothing here is wired yet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013y1CvsXqLFMRgAW7TXJQMs * Rename native epochs to v15/v4 and wire the frozen v14 provider Rename engine/host and order namespaces, the host capability macro, and consumer/broker/stream identity markers without changing engine behavior or existing C++ numeric assertions. Preserve the six measured files and normalize only the identity header's stale namespace comment. Generalize the ABI fence to the reviewed v13/v14-to-v15 pairs, pin the Phase-0 header bytes, and derive authenticated provider owners and each caller's order shape. Prepare and verify the frozen f736676 v14 archive alongside e60, 0e, v13 and current v15, including unchanged-driver links. Stage complete execution-terms/FX callers and the named negative compile control behind the Phase-1c readiness gate. Activate the authenticated v14 compile control, retain all old order-v1 pairs, and update registered Python mirrors, CMake receipts, CI diagnostics and epoch documentation. Validation: ci_preflight passed; full Release ci_verify passed all 334 registered tests with zero failures/skips; the unregistered native-feed mirror passed 5 tests. The five-archive matrix passed 49 compiles and 118 links. R-EPOCH matches the 16 recorded historical/control residuals. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com> * Add the native FX-curve value header and its validation Add NativeFxCurve v1 values, ordered validation, and the total length-prefixed FNV digest. Register the source and validation/digest test, plus exact ownership, include-freedom, and introduced-at controls. Contract: §3.4, §6, §7 1a, Appendix C rows 32 and 40, amendment A5. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com> * Add native_order_v4 execution terms core with deferred sizing and exact reversal Add the v4 order terms surface, deferred allowance and authenticated binding receipts, exact reversal and whole-close accounting, durable receipt hashing, ABI shape pins, and core witnesses. Contract: §3.1, §4.1–§4.2, §6, §7 (landing 1b), §8 (A-T1, A-T3, A-T4, A-T4d, A-R5, A-R6, A-S2, A-S3, A-S4, A-H1, A-1). Co-Authored-By: Codex gpt-6-astra <noreply@openai.com> * Declare the v15 native host terms, precommit and FX-curve surface Add the complete v15 host values, identity resolver and precommit defaults, plus Ready-only FX-curve staging with a durable continuation-hash fold. Register the five phase-1 seed witnesses, re-pin the host ABI bytes, and activate the V15 ABI controls and mirrors. Contract: §3.2, §3.5, §4.4, §6, §7 (Landing 1c), A-1, A-A2. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Pin the A-R6 reversal accounting witnesses fully Fully assert reversal allowance and remaining projections, including the absorbed-turnover witness. Contract rules: §3.1, §4.2, §8 A-R6, §9 A-0. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Implement native execution terms coordinator Add the W2 resolver, matcher provenance, plan dispatch, precommit, and FX activation seams under R4-B §§3.2, 3.3, 3.5, 4.1–4.4, 5, and amendment A1/A2.\n\nA6: append and hash the durable shared_cursor_collision receipt field. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Add native terms coordinator witnesses Exercise host-sized terms, provenance collisions, reversal/whole-close plans, precommit barriers, FX activation, and durable replay/serializer branches under R4-B §7–§8 and amendments A1–A4. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Cover native terms provenance and serialization Add test-only oracle, current terms facts, deferred cancellation, collision replay, projection barriers, and executable replay/market/calendar serializer controls for R4-B §7–§10 and amendments A1–A4. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Validate native host terms before receipt Reject invalid opening-shape values and limit-breaching host prices before receipt installation under R4-B §4.1. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Expand native terms acceptance matrix Add literal W2 coordinator witnesses for R4-B §8 terms, reversal, precommit, FX, provenance, and post-hook rows. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Add literal W2 terms acceptance rows Cover expanded R4-B §8 terms, price provenance, reversal, precommit, FX, and hash/replay witnesses in the assigned W2 test files. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Broaden W2 acceptance witnesses Add queued cancellation, price-kind, price-boundary, exact reversal, barrier, and fresh-replay acceptance rows required by R4-B §8. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Complete W2 replay and serializer controls Add assigned W2 provenance, precommit barrier, replay hash, and calendar binary64 serializer acceptance coverage under R4-B §7–§8. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Strengthen current facts and FX sink coverage Add all current fact-shape comparisons and native candidate timestamp sink witnesses for assigned R4-B W2 rows. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Exercise precommit cycle exhaustion boundary Add the W2 A-P4 pre-effects cycle-exhaustion witness with zero validator calls. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Fix native terms review defects Address zero-unit nonpositive terms, callback activation timestamp, provenance invalidation, and complete TermsResolved serializer coverage per W2 review D1-D3. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Complete durable terms serialization and replay tests Serialize complete TermsResolved identities/projections and add real market/calendar lifecycle plus appended-history replay witnesses for D3/D4. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Preserve zero-unit terms across price fences Ensure valid HostSized zero terminals install their receipt and NoEffect even at nonpositive or limit-side prices. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * docs: correct carried FX rollover support Correct the public C ABI documentation to state that carried 1× long and short positions are supported while leveraged positions fail closed. Contract: §3.4, §6, §11, Appendix C row 35. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com> * Add native FX curve C ABI transport Add the Ready-only FX curve C entry, runtime export inventory, and direct and dynamic C caller coverage. Extend the v15 ownership and exact-count ABI fences with registered mirrors. Contract: §3.4, §6, §7; A-F1, A-A1, A-A2, A-E2. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * docs: describe native execution terms v15 Document the R4-B native terms, exact reversal, precommit, FX-curve, ABI transition, and runner examples. Contract: §3.2, §3.4, §3.6, §6, §7 W4, §11; A-E1, A-E2. Co-Authored-By: Codex gpt-6-astra <noreply@openai.com> * test: add native selected strategy example Add the v15 selected native runner module, its dynamic batch/stream test, and the final ABI/example documentation refinements. Contract: §7 W4, §8 fail-before protocol, A-E1, A-E2, and R-EPOCH. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * docs: correct the native refactor progress record Record PR #247 and PR #248 as completed R3 milestones, and separate PR #246 historical epoch-13 state from the current R4-B baseline. Contract: §6 R-EPOCH rule 3; Appendix A; A-E2. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * docs: add native refactor worker guidance Apply the root-authored worker guidance patches for the R4-B integration. Contract: R4-B §§0, 7, 8, 9. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * fix: re-pin reviewed native ABI headers Re-pin the recorded A6 native_order and integrated native_host bytes after phase-3 review. Contract: R4-B §§6–7; amendment A6. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> * Drop identity attempted terms and complete the terms acceptance rows Repair the explicit identity ReverseTo rejection metadata and add literal A-T5, A-T6, A-T9, A-S2, A-P1, and A-F7 witnesses. Contract: §3.1, §4.1-§4.4, §8; A-T5, A-T6, A-T9, A-S2, A-P1, A-F7. Co-Authored-By: Codex gpt-5.6-terra <noreply@openai.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Codex gpt-6-astra <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native settlement previously rejected otherwise valid fills when unrelated source-day counters or intraday PnL were exhausted or invalid, and native closes updated Pine chart-day state. This change keeps those checks and observations in the three source compatibility coordinators while making explicit native settlement independent of them.
Validation: all nine GitHub checks passed on the first attempt at
33d1b73. Standard and sanitizer profiles passed 330 tests; native passed 338 with no skips, including required WebSocket support. All six profiles passed 22 real-library ABI link checks. Boundary tests passed 2,448 checks, native-host tests passed 432, and all 29 source-precedence witnesses remain byte-identical to the accepted baseline. Exact-tree independent review is GREEN.The complete Cloud sweep measured all 72 cases and 4,190 observations/verifier reports. Trade CSVs, full grades, substantive verifier documents, configuration and coverage are identical to accepted PR247 candidate
824d5d3.The actual gate returned FAIL
target.not-positive; baseline and candidate grade documents are identical. Root accepted the neutral refactor under the user's standing non-regression authorization, preserving the real FAIL and deferred baseline promotion. Squash-tree equality and post-merge CI remain separate verification. R4 codegen/adapter lowering and the final requirement audit are still open.