Add docs about tidb_columnar_storage_enabled - #21910
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
📝 WalkthroughWalkthroughChanges列存存储开关文档
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The documentation may imply that this setting applies to all storage architectures and that tenants can change it directly, which could lead to incorrect configuration guidance. The PR is otherwise mergeable with explicit owner follow-up to clarify applicability and TiDB X permissions. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 73d5b5fd-02fa-4453-a3f3-c639c00db783
📒 Files selected for processing (3)
system-variable-reference.mdsystem-variables.mdtiflash/create-tiflash-replicas.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| - 作用域：GLOBAL | ||
| - 是否持久化到集群：是 | ||
| - 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制：否 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
说明 TiDB X 中的设置入口和权限。
当前内容只说明变量可以使用 GLOBAL 作用域持久化。TiDB X 中该变量由控制面设置，租户不应直接执行 SET GLOBAL 修改。请补充这一限制，并区分自建集群的权限行为。 (github.com)
可直接提交的替换文本
- 作用域：GLOBAL
- 是否持久化到集群：是
- 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制：否
+ - 在 TiDB X 中，该变量由控制面设置，租户不应直接执行 `SET GLOBAL` 修改；自建集群可按权限修改。As per path instructions：对 **/*.md 文件，能够安全替换连续行时必须提供精确的可提交替换文本。
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - 作用域：GLOBAL | |
| - 是否持久化到集群：是 | |
| - 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制：否 | |
| - 作用域：GLOBAL | |
| - 是否持久化到集群：是 | |
| - 是否受 Hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value) 控制：否 | |
| - 在 TiDB X 中，该变量由控制面设置，租户不应直接执行 `SET GLOBAL` 修改；自建集群可按权限修改。 |
Sources: Path instructions, MCP tools
1 participant
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add a new global variable
tidb_columnar_storage_enabledthat is introduced by pingcap/tidb#70524Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
tidb_columnar_storage_enabled系统变量说明，涵盖默认值、引入版本及对 TiFlash/列存相关 DDL 的影响。