Add warnings about tikv#19891 to affected 8.5.x - #21914
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
📝 WalkthroughWalkthrough为 TiDB 8.5.3 至 8.5.7 的发布说明新增警告块。警告说明这些版本存在已知问题，并建议使用 8.5.x 的最新版本。 Changes发布说明更新
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR adds warnings to affected TiDB 8.5.x release notes. The warning should explicitly reference TiKV Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
新增警告与 PR 标题中的 tikv#19891 不一致且缺少具体问题与修复版本信息，用户无法据此判断风险与升级目标版本。
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
本 PR 旨在为受影响的 TiDB 8.5.x（8.5.3~8.5.7）版本发布说明增加“已知问题/建议升级”的醒目提示，以降低用户误用存在已修复问题的旧版本的风险。
Changes:
- 在 8.5.3、8.5.4、8.5.5、8.5.6、8.5.7 的 Release Notes 头部新增统一的“警告”提示块。
- 警告内容目前为通用表述，提示“建议使用 8.5.x 的最新版本”。
File summaries
| File | Description |
|---|---|
| releases/release-8.5.7.md | 在版本信息后新增“警告”提示块，提醒升级到 8.5.x 最新版本。 |
| releases/release-8.5.6.md | 在版本信息后新增“警告”提示块，提醒升级到 8.5.x 最新版本。 |
| releases/release-8.5.5.md | 在版本信息后新增“警告”提示块，提醒升级到 8.5.x 最新版本。 |
| releases/release-8.5.4.md | 在版本信息后新增“警告”提示块，提醒升级到 8.5.x 最新版本。 |
| releases/release-8.5.3.md | 在版本信息后新增“警告”提示块，提醒升级到 8.5.x 最新版本。 |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 8.5.x 的最新版本。 |
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 8.5.x 的最新版本。 |
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 8.5.x 的最新版本。 |
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 8.5.x 的最新版本。 |
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 8.5.x 的最新版本。 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 80435ecf-889a-4eb2-8807-e4b08f5eebc9
📒 Files selected for processing (5)
releases/release-8.5.3.mdreleases/release-8.5.4.mdreleases/release-8.5.5.mdreleases/release-8.5.6.mdreleases/release-8.5.7.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 8.5.x 的最新版本。 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
统一引用 tikv#19891。
五个发布说明都使用无法追踪的“存在一些已知问题”描述。请在每个位置明确引用 TiKV #19891``，以便用户确认风险并查看问题详情。
releases/release-8.5.3.md#L14-L14: 将警告文本替换为包含TiKVrefine admin related docs #19891`` 链接的版本。releases/release-8.5.4.md#L14-L14: 将警告文本替换为包含TiKVrefine admin related docs #19891`` 链接的版本。releases/release-8.5.5.md#L14-L14: 将警告文本替换为包含TiKVrefine admin related docs #19891`` 链接的版本。releases/release-8.5.6.md#L14-L14: 将警告文本替换为包含TiKVrefine admin related docs #19891`` 链接的版本。releases/release-8.5.7.md#L14-L14: 将警告文本替换为包含TiKVrefine admin related docs #19891`` 链接的版本。
As per path instructions：对于 **/*.md，可安全替换的连续行必须提供 GitHub 可提交的 suggestion 块。
📍 Affects 5 files
releases/release-8.5.3.md#L14-L14(this comment)releases/release-8.5.4.md#L14-L14releases/release-8.5.5.md#L14-L14releases/release-8.5.6.md#L14-L14releases/release-8.5.7.md#L14-L14
Source: Path instructions
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add warnings about tikv/tikv#19891 to affected 8.5.x
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?