Add warnings about tikv#19891 to affected 7.5.7 - #21915
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
Do not merge, waits for v7.5.8. |
📝 WalkthroughWalkthroughTiDB 7.5.7 发布说明新增警告，说明该版本存在已知问题，并建议使用 7.5.x 的最新版本。 Changes发布说明更新
Estimated code review effort: 1（简单） | ~2 分钟 Merge Risk: 🟡 Moderate · up to The release note currently does not clearly identify the affected TiDB versions, the TiKV failure scenario, or how users should avoid the problem, so users may incorrectly believe the latest 7.5.x release is safe. Update the warning before merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 17324485-5300-4c65-8c25-656c24bbd52f
📒 Files selected for processing (1)
releases/release-7.5.7.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
|
|
||
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 7.5.x 的最新版本。 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
请改为具体且可执行的 tikv/tikv#19891 警告。
当前文字没有给出 issue 编号、受影响版本或故障表现。“已在新版本中修复”也没有具体版本号。该 issue 标记影响 7.5.x，并报告特定事务场景下 TiKV 可能 panic 及进入崩溃循环；当前发布列表中，7.5.7 仍是列出的最新 7.5.x 版本。因此，“使用 7.5.x 的最新版本”不会引导用户离开受影响版本。(github.com)
提交可用的文字替换
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 7.5.x 的最新版本。 | |
| > TiKV 存在 [`tikv/tikv#19891`](https://github.com/tikv/tikv/issues/19891) 已知问题。该问题影响 TiDB 7.5.x，TiDB 7.5.7 属于受影响范围；在特定事务场景下，TiKV 可能 panic 并进入崩溃循环。请在升级前确认所选版本包含对应修复，并关注后续 7.5.x 版本。 |
As per path instructions: 对 Markdown 中可连续、安全替换的可行动问题提供可提交的 suggestion。
Sources: Path instructions, MCP tools
There was a problem hiding this comment.
🟡 Changes recommended
新增的警告内容与 PR 声称要提示的 tikv/tikv#19891 不够一致且信息过于笼统，并且 PR 描述/适用版本勾选与实际改动范围存在不一致。
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
该 PR 旨在为 TiDB 7.5.7 发布说明补充“警告”提示，提醒读者该版本存在已知问题并建议升级到 7.5.x 最新补丁版本，从而降低用户在生产环境中使用旧补丁版本的风险。
Changes:
- 在
release-7.5.7.md的版本信息后新增“警告”提示块，建议使用 7.5.x 最新版本。
File summaries
| File | Description |
|---|---|
| releases/release-7.5.7.md | 在 7.5.7 Release Notes 顶部新增警告提示，提醒存在已知问题并建议升级。 |
Review details
Suppressed comments (1)
releases/release-7.5.7.md:12
- PR 描述里写的是“添加 tikv/tikv#19891 的警告到受影响的 8.5.x”，但本次实际只改动了
release-7.5.7.md，且版本勾选也未选择 v8.5。请统一 PR 标题/描述/适用版本勾选与改动范围，避免后续合并或 cherry-pick 时产生误解。
> **警告：**
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| > **警告：** | ||
| > | ||
| > 该版本存在一些已知问题，已在新版本中修复，建议使用 7.5.x 的最新版本。 |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add warnings about tikv/tikv#19891 to affected 8.5.x
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit