v8.5.6 release notes: add info about cluster_id (#22766)#22793
v8.5.6 release notes: add info about cluster_id (#22766)#22793ti-chi-bot wants to merge 1 commit intopingcap:release-8.5from
cluster_id (#22766)#22793Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the release notes for v8.5.6 by adding a section on system table changes, specifically documenting the addition of the cluster_id field to the mysql.tidb table. A review comment suggests improving the conciseness of the description by removing redundant phrasing regarding the read-only nature of the field and simplifying the sentence structure.
|
|
||
| | System table | Change type | Description | | ||
| | -------- | -------- | -------- | | ||
| | [`mysql.tidb`](https://docs.pingcap.com/tidb/v8.5/mysql-schema#cluster-status-system-tables) | Modified | Adds the `cluster_id` field, which represents the unique identifier of a TiDB cluster. Note that `cluster_id` is read-only and cannot be modified. | |
There was a problem hiding this comment.
The description is slightly wordy and contains redundant information. Since "read-only" already implies that the field cannot be modified, the phrase "and cannot be modified" is unnecessary. Additionally, "which represents" can be simplified to "which is" for better clarity and conciseness, following the repository's writing principles to avoid unnecessary words.
| | [`mysql.tidb`](https://docs.pingcap.com/tidb/v8.5/mysql-schema#cluster-status-system-tables) | Modified | Adds the `cluster_id` field, which represents the unique identifier of a TiDB cluster. Note that `cluster_id` is read-only and cannot be modified. | | |
| | [`mysql.tidb`](https://docs.pingcap.com/tidb/v8.5/mysql-schema#cluster-status-system-tables) | Modified | Adds the `cluster_id` field, which is the unique identifier of the TiDB cluster. This field is read-only. | |
This is an automated cherry-pick of #22766
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
cluster_iddocs-cn#21559Do your changes match any of the following descriptions?