docs: add statement summary system variables - #23001
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds documentation for two new system variables introduced in TiDB v8.5.7: tidb_stmt_summary_group_by_user and tidb_stmt_summary_persist_evicted. The changes span across statement-summary-tables.md, system-variable-reference.md, and system-variables.md. The review comments suggest rewriting several sentences to use the active voice, reducing wordiness, and using "who" instead of "that" when referring to users, in alignment with the repository's documentation style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe documentation adds two GLOBAL statement summary variables. It describes user-based aggregation, LRU-evicted record persistence, defaults, memory effects, log output, history query behavior, and TiDB Cloud restrictions. ChangesStatement summary configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds documentation for two statement summary system variables without changing product behavior or runtime configuration; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the changes, identifies the affected files, provides the translated source PR, and records completed checks. It omits the required affected-version checklist and other template checklists, but it is otherwise sufficiently complete and on topic. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed
This PR is translated from: pingcap/docs-cn#21694
Add English documentation for two statement summary system variables, corresponding to pingcap/docs-cn#21694:
Updated files:
Check List
Tests:
Summary by CodeRabbit
New Features
evictedmarker.Documentation