system-variables: add tidb_paging_size_bytes (internal use) (#23565) - #23681
system-variables: add tidb_paging_size_bytes (internal use) (#23565)#23681ti-chi-bot wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughAdds reference documentation for the ChangesPaging variable documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change adds reference documentation for the internal paging-size system variable. No current documentation defect affecting configuration behavior or users remains identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a3c708e1-3e4c-4aaf-aa4b-38b6b587c48e
📒 Files selected for processing (1)
system-variables.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
|
||
| - Scope | ||
| - TiDB Self-Managed: SESSION | GLOBAL | ||
| - TiDB Cloud Essential and Premium: SESSION |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
printf '%s\n' '--- applicable conventions ---'
find /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c -path '*/\*.md' -print | sort
printf '%s\n' '--- target entry ---'
sed -n '5398,5424p' system-variables.md
printf '%s\n' '--- resource-control references ---'
rg -n -C 4 'Essential|non-burst|nonburstable|Resource Control|tidb_paging_size_bytes' \
--glob '*.md' \
/tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c system-variables.mdRepository: pingcap/docs
Length of output: 5045
🏁 Script executed:
printf '%s\n' '--- applicable conventions ---'
find /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c -type f -name '*.md' -print | sort
printf '%s\n' '--- target entry ---'
sed -n '5398,5424p' system-variables.md
printf '%s\n' '--- resource-control references ---'
rg -n -C 4 'Essential|non-burst|nonburstable|Resource Control|tidb_paging_size_bytes' \
--glob '*.md' \
/tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c system-variables.mdRepository: pingcap/docs
Length of output: 5310
🏁 Script executed:
printf '%s\n' '--- repository convention ---'
cat /tmp/coderabbit-repo-knowledge/pingcap-docs-9c73f70c/conventions/repo-wide.md
printf '%s\n' '--- resource-control document ---'
resource_doc=$(find . -name 'tidb-resource-control-ru-groups.md' -print -quit)
if [ -n "$resource_doc" ]; then
rg -n -C 5 'Starter|Essential|Premium|fixed RU|non-burst|burstable|Resource Control' "$resource_doc"
else
printf '%s\n' 'resource-control document not present in checkout'
fiRepository: pingcap/docs
Length of output: 7668
Clarify TiDB Cloud Essential availability.
Resource Control is unavailable on TiDB Cloud Essential, but this variable requires Resource Control to take effect. Remove Essential from the scope, or document the internal exception that provides the required Resource Group.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an automated cherry-pick of #23565
What is changed, added or deleted? (Required)
This PR is translated from: pingcap/docs-cn#21752
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Summary by CodeRabbit
tidb_paging_size_bytessystem variable for limiting coprocessor response pages by byte size.SET_VARsupport, and availability.