Skip to content

workload: add more workload#4877

Draft
wk989898 wants to merge 7 commits intopingcap:masterfrom
wk989898:workload-0421
Draft

workload: add more workload#4877
wk989898 wants to merge 7 commits intopingcap:masterfrom
wk989898:workload-0421

Conversation

@wk989898
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

Signed-off-by: wk989898 <nhsmwk@gmail.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 21, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign asddongmen for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 270b7a2b-e2c3-4609-82e6-a3db8f3d3877

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 21, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the bank4 workload, which is optimized for partition-heavy DDL stress testing with a schema that includes 126 monthly partitions. It also refactors the DDLRunner to schedule DDL tasks evenly throughout the minute, improving the consistency of the workload. Review feedback points out that the bank4 DDL generator currently only supports TRUNCATE TABLE, which limits the effectiveness of mixed DDL configurations. Additionally, a performance optimization was suggested for the INSERT statement generation to reduce memory allocations by using fmt.Fprintf instead of fmt.Sprintf inside loops.

Comment on lines +246 to +249
func (c *BankWorkload) BuildDDLSql(opts schema.DDLOption) string {
tableName := getBankTableName(opts.TableIndex)
return fmt.Sprintf("truncate table %s;", tableName)
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The BuildDDLSql implementation always returns a TRUNCATE TABLE statement, regardless of the DDL type intended by the scheduler (e.g., add_column, add_index). This makes the rate_per_minute configuration for other DDL types in the provided examples (like ddl_partition_table_mixed.toml) misleading, as they will all result in table truncations. Consider updating the DDLWorkload interface to include the DDL type or implementing logic to vary the DDL statement generated here.

Comment on lines +143 to +175
buf.WriteString(fmt.Sprintf(
"('%s','%s','%s','%s','%s','%s','%s','%s','%s',%d,%d,'%s',%d,'%s','%s','%s','%s','%s','%s','%s','%s','%s',%d,'%s','%s','%s','%s',%d,%d,%d)",
col1Value,
col2Value,
col3Value,
col4Value,
col5Value,
col6Value,
col7Value,
col8Value,
col9Value,
col10Value,
col11Value,
col12Value,
col13Value,
col14Value,
col15Value,
col16Value,
col17Value,
col18Value,
col19Value,
col20Value,
col21Value,
col22Value,
col23Value,
col24Value,
col25Value,
col26Value,
col27Value,
col28Value,
col29Value,
col30Value,
))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using fmt.Sprintf inside a loop to build a large string can be inefficient due to multiple allocations. It is better to use fmt.Fprintf to write directly into the bytes.Buffer.

		fmt.Fprintf(&buf, "('%s','%s','%s','%s','%s','%s','%s','%s','%s',%d,%d,'%s',%d,'%s','%s','%s','%s','%s','%s','%s','%s','%s',%d,'%s','%s','%s','%s',%d,%d,%d)",
			col1Value, col2Value, col3Value, col4Value, col5Value, col6Value, col7Value, col8Value, col9Value, col10Value,
			col11Value, col12Value, col13Value, col14Value, col15Value, col16Value, col17Value, col18Value, col19Value, col20Value,
			col21Value, col22Value, col23Value, col24Value, col25Value, col26Value, col27Value, col28Value, col29Value, col30Value)

Signed-off-by: wk989898 <nhsmwk@gmail.com>
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 21, 2026
Signed-off-by: wk989898 <nhsmwk@gmail.com>
.
Signed-off-by: wk989898 <nhsmwk@gmail.com>
Signed-off-by: wk989898 <nhsmwk@gmail.com>
Signed-off-by: wk989898 <nhsmwk@gmail.com>
.
Signed-off-by: wk989898 <nhsmwk@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 21, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant