Implement scale subresource on Pod owners#6912
Conversation
|
Hi @SuperQ. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6912 +/- ##
=======================================
Coverage 37.97% 37.97%
=======================================
Files 393 393
Lines 22605 22605
=======================================
Hits 8584 8584
Misses 14021 14021
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
In order for PodDisruptionBudgets to work on various groups of Pods
we need to implement the Scale subresource at the direct owner of
the Pod.
Otherwise the PDB will return errors like:
```yaml
status:
conditions:
- lastTransitionTime: "2026-04..."
message: tikvs.core.pingcap.com does not implement the scale subresource
reason: SyncFailed
status: "False"
type: DisruptionAllowed
```
Followup to pingcap#6213
Signed-off-by: SuperQ <superq@gmail.com>
7ece3ee to
decc403
Compare
|
/lgtm |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liubog2008 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-2.1 |
|
@liubog2008: once the present PR merges, I will cherry-pick it on top of release-2.1 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@SuperQ: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In order for PodDisruptionBudgets to work on various groups of Pods we need to implement the Scale subresource at the direct owner of the Pod.
Otherwise the PDB will return errors like:
Followup to #6213
Closes: #6901
Closes: #4221