Skip to content

Implement scale subresource on Pod owners#6912

Open
SuperQ wants to merge 1 commit into
pingcap:mainfrom
SuperQ:superq/tikv_scale_subresource
Open

Implement scale subresource on Pod owners#6912
SuperQ wants to merge 1 commit into
pingcap:mainfrom
SuperQ:superq/tikv_scale_subresource

Conversation

@SuperQ
Copy link
Copy Markdown
Contributor

@SuperQ SuperQ commented May 22, 2026

In order for PodDisruptionBudgets to work on various groups of Pods we need to implement the Scale subresource at the direct owner of the Pod.

Otherwise the PDB will return errors like:

status:
  conditions:
    - lastTransitionTime: "2026-04..."
      message: tikvs.core.pingcap.com does not implement the scale subresource
      reason: SyncFailed
      status: "False"
      type: DisruptionAllowed

Followup to #6213

Closes: #6901
Closes: #4221

@ti-chi-bot ti-chi-bot Bot requested review from howardlau1999 and shonge May 22, 2026 06:18
@github-actions github-actions Bot added the v2 for operator v2 label May 22, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 22, 2026

Hi @SuperQ. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the size/L label May 22, 2026
@SuperQ
Copy link
Copy Markdown
Contributor Author

SuperQ commented May 22, 2026

👓 @liubog2008

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.97%. Comparing base (fe02609) to head (decc403).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6912   +/-   ##
=======================================
  Coverage   37.97%   37.97%           
=======================================
  Files         393      393           
  Lines       22605    22605           
=======================================
  Hits         8584     8584           
  Misses      14021    14021           
Flag Coverage Δ
unittest 37.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

In order for PodDisruptionBudgets to work on various groups of Pods
we need to implement the Scale subresource at the direct owner of
the Pod.

Otherwise the PDB will return errors like:

```yaml
status:
  conditions:
    - lastTransitionTime: "2026-04..."
      message: tikvs.core.pingcap.com does not implement the scale subresource
      reason: SyncFailed
      status: "False"
      type: DisruptionAllowed
```

Followup to pingcap#6213

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ force-pushed the superq/tikv_scale_subresource branch from 7ece3ee to decc403 Compare May 22, 2026 06:31
@ti-chi-bot ti-chi-bot Bot added size/XL and removed size/L labels May 22, 2026
@liubog2008
Copy link
Copy Markdown
Member

/lgtm

@ti-chi-bot ti-chi-bot Bot added the lgtm label May 25, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-25 04:38:47.624073109 +0000 UTC m=+240597.594238176: ☑️ agreed by liubog2008.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 25, 2026
@liubog2008
Copy link
Copy Markdown
Member

/cherry-pick release-2.1

@ti-chi-bot
Copy link
Copy Markdown
Member

@liubog2008: once the present PR merges, I will cherry-pick it on top of release-2.1 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2026

@SuperQ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e decc403 link true /test pull-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PDB for k8s cluster version upgrade Support PodDisruptionBudget in v2

4 participants