Skip to content

Support graceful shutdown in TiFlash (release-7.5) (#10299)#10312

Open
ti-chi-bot wants to merge 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-10299-to-release-7.5
Open

Support graceful shutdown in TiFlash (release-7.5) (#10299)#10312
ti-chi-bot wants to merge 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-10299-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 15, 2025 •
edited by gengliqi
Loading

This is an automated cherry-pick of #10299 and #10313 and #10317

What problem does this PR solve?

Issue Number: close #10266

Problem Summary:

What is changed and how it works?

Should merge #10298 first.

Support graceful shutdown in TiFlash again

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support graceful shutdown in TiFlash

@gengliqi @ti-chi-bot
Support graceful shutdown in TiFlash again (pingcap#10299)
18c4684 
close pingcap#10266

Support graceful shutdown in TiFlash again

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jul 15, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 15, 2025
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jul 15, 2025

/test pull-integration-test

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-15 14:57:44.633333386 +0000 UTC m=+2616517.356512363: ☑️ agreed by gengliqi.
  • 2025-07-15 15:55:47.595597755 +0000 UTC m=+2620000.318776736: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jul 16, 2025

/test pull-integration-test

@gengliqi
add pingcap#10312
821266e 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@JaySon-Huang JaySon-Huang changed the title Support graceful shutdown in TiFlash again (#10299) Support graceful shutdown in TiFlash (release-7.5) (#10299) Jul 24, 2025
gengliqi added 2 commits July 24, 2025 16:31
@gengliqi
u
5c021e2 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
cherry-pick Rename graceful_wait_before_shutdown to graceful_wait_shu…
63cf668 
…tdown_timeout pingcap#10317

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2025 •
edited
Loading

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test 63cf668 link true /test pull-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

@gengliqi gengliqi

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @JaySon-Huang @gengliqi