Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This updates the vendored markdown renderer and its dependency references to correct Android file-link pill text scaling. The runtime effect is narrowly limited to existing mobile markdown rendering, with no product-default, schema, security, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
Picks up pingdotgg/enriched-markdown#8, which resets the pill label's horizontal text scale so it no longer inherits inline code's narrowed padding space. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9701546 to
76ef9e7
Compare
|
Note Written by Retained the merge review's packaging change: Merged the one newer main commit without conflicts or rebasing and pushed Fresh Blacksmith verification passed Final-archive Android rendering remains unverified. No device is connected, and the environment's device tool reports access is turned off. Chrome cannot exercise this Kotlin renderer. The earlier Android verification comment covers the previous archive and remains historical evidence. Before calling this ready, rebuild Android and check inline-code pill width, truncation, tap, long-press, and ordinary inline code. |
|
Note Written by Verified on Android emulator (API 35) against a real dev serverVerified head File labels from explicit markdown links with inline-code labels render at normal horizontal width. Ordinary inline code, bold file links, and italic file links also render correctly. Tapping README.md and EnrichedMarkdownText.tsx opens their actual workspace files. Long-pressing README.md shows the full path and copy/open actions. The recording shows file opening, returning to chat, and the long-press menu. The before comparison is the same app and response rebuilt with only this PR's two-line native reset removed. Its LinkPillSpan.kt matches the unpatched t3.16 archive byte for byte. Both builds render without squishing, consistent with main having already removed the original padding span. This verifies the current build and neighboring interactions; it does not demonstrate a new visible improvement over t3.16. Before, unpatched t3.16 renderer: After, exact PR native build restored and checked again: No source changes were needed. GitCafe reported 28 successful checks. A final GitHub read reported 22 successful, six skipped, and one cancelled (Native fingerprint diff), with no failing or pending checks. The original MP4 was played and seeked in T3's browser preview; the embed is an animated copy of that recording. Not verified
|
|
@maria-rcks ur clanker trippin there's no difference lol. This probably regressed at some point. And now it's fixed. So I don't think there's any need to keep this open. |



Android file-link pill labels should keep normal horizontal text scale when their paint comes from an inline-code run. The original regression inherited the narrowed padding run's scale. This is a focused bug fix with no product or interface changes.
Merged current main without rebasing and retained the contributor's
textScaleX = 1freset. The reset is now committed on the renderer'sfork/t3-mobilebranch at2f2ee98abf191d628df5c0586ac995e762d789feand included in a repacked t3.16 archive perapps/mobile/deps/README.md. The temporary pnpm patch and its workspace and lockfile entries are removed. The package, allow-build, and lockfile references use the new archive. A native Android rebuild is required.All 1,220 archive entries were compared with main's archive. Only the single Kotlin reset and source-commit metadata changed. Measurement, truncation, and drawing use the same styled paint. The package version, JavaScript, iOS, and generated code are unchanged.
Blacksmith verification passed:
vp run check:changed(39 package typechecks, format, knip, unused-patch installation and agent-context test), all eight existing mobile markdown-link tests, and Kotlin native static analysis (vp run lint:mobile). SwiftLint is unavailable on the Linux worker. Two independent source and archive reviews approved head74e1de9daf5cd112b53b115fcf45d5930b097da8with no code findings.Final-archive Android rendering is unverified in this run: no Android device or emulator is installed or connected, and Chrome cannot exercise this Kotlin renderer. The earlier Android verification comment covers the previous patched archive; it remains historical evidence. The images below cover the contributor's original t3.15 build, not this repacked archive. Before merging, rebuild the native Android client and check inline-code file-pill width, opening files, long-press actions, and ordinary inline code.
Updated by gpt-6.1-sol through the Codex harness in T3 Code.