Fix desktop context menu rendering#280
Fix desktop context menu rendering#280krishkalaria12 wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
@krishkalaria12 is attempting to deploy a commit to the Ping Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Not sure what happened to the diff but github is now convinced you edited a bunch of stuff you didn't. Rebase on main I guess |
Cleaned it up and dropped the unrelated desktop dev-script change. It was already on top of |
|
@krishkalaria12 pls resolve conflicts / rebase |
917efbc to
424397e
Compare
I have resolved the conflicts,, can you check once ? |
Deletecontextmenupropagation on sidebar rows and fix the desktop dev script sobun run dev:desktopreliably starts both the bundle watcher and ElectronNote
Fix desktop context menu rendering by replacing native Electron menus with in-app fallback
CONTEXT_MENU_CHANNELIPC handler in main.ts and theshowContextMenubridge method in preload.ts.contextMenu.showin wsNativeApi.ts now always callsshowContextMenuFallback, ignoring any desktop bridge.pointerdowncapture listener, adds entrance animation, clamps the menu to viewport edges, and inserts a visual separator before destructive items.event.stopPropagation()to context menu handlers on project titles and thread items in Sidebar.tsx to prevent event bubbling.Macroscope summarized 424397e.