Skip to content

Fix desktop context menu rendering#280

Open
krishkalaria12 wants to merge 2 commits intopingdotgg:mainfrom
krishkalaria12:fix/context-menu-desktop
Open

Fix desktop context menu rendering#280
krishkalaria12 wants to merge 2 commits intopingdotgg:mainfrom
krishkalaria12:fix/context-menu-desktop

Conversation

@krishkalaria12
Copy link

@krishkalaria12 krishkalaria12 commented Mar 7, 2026

image
  • replace the desktop native context menu path with the in-app renderer menu so thread/project right-click menus no longer show the extra backdrop layer in the frameless window
  • clean up the fallback context menu rendering by resetting native button chrome, keeping a single menu surface, preserving outside-click/escape dismissal, and adding the destructive separator before Delete
  • stop contextmenu propagation on sidebar rows and fix the desktop dev script so bun run dev:desktop reliably starts both the bundle watcher and Electron

Note

Fix desktop context menu rendering by replacing native Electron menus with in-app fallback

  • Removes the native Electron context menu implementation from the desktop main process, including the CONTEXT_MENU_CHANNEL IPC handler in main.ts and the showContextMenu bridge method in preload.ts.
  • contextMenu.show in wsNativeApi.ts now always calls showContextMenuFallback, ignoring any desktop bridge.
  • The fallback in contextMenuFallback.ts is reworked: replaces the full-screen overlay with a pointerdown capture listener, adds entrance animation, clamps the menu to viewport edges, and inserts a visual separator before destructive items.
  • Adds event.stopPropagation() to context menu handlers on project titles and thread items in Sidebar.tsx to prevent event bubbling.
  • Behavioral Change: context menus on desktop no longer use native OS rendering; all platforms now use the in-app fallback UI.

Macroscope summarized 424397e.

@vercel
Copy link

vercel bot commented Mar 7, 2026

@krishkalaria12 is attempting to deploy a commit to the Ping Labs Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3b2993b0-51f0-4f2d-823f-1170c9fafe25

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
t3code-marketing Ready Ready Preview, Comment Mar 7, 2026 10:16am

Request Review

@t3dotgg
Copy link
Member

t3dotgg commented Mar 7, 2026

Not sure what happened to the diff but github is now convinced you edited a bunch of stuff you didn't. Rebase on main I guess

@krishkalaria12
Copy link
Author

Not sure what happened to the diff but github is now convinced you edited a bunch of stuff you didn't. Rebase on main I guess

Cleaned it up and dropped the unrelated desktop dev-script change. It was already on top of main, so no real rebase was needed i guess

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 9, 2026
@maria-rcks
Copy link
Collaborator

@krishkalaria12 pls resolve conflicts / rebase

@maria-rcks maria-rcks added enhancement New feature or request needs-julius labels Mar 12, 2026
@krishkalaria12 krishkalaria12 force-pushed the fix/context-menu-desktop branch from 917efbc to 424397e Compare March 12, 2026 03:57
@krishkalaria12
Copy link
Author

@krishkalaria12 pls resolve conflicts / rebase

I have resolved the conflicts,, can you check once ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-julius vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants